fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json #30133
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
target: major
It has a dependency on @angular/upgrade which is not part of the dependencies in package.json, so postinstall would fail.
IgorMinar
added
target: patch
alexeagle
approved these changes
Apr 26, 2019
IgorMinar
approved these changes
Apr 26, 2019
alexeagle
added
the
merge: caretaker note
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 26, 2019
It has a dependency on @angular/upgrade which is not part of the dependencies in package.json, so postinstall would fail. PR Close #30133
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…r#30133) It has a dependency on @angular/upgrade which is not part of the dependencies in package.json, so postinstall would fail. PR Close angular#30133
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information