fix(language-service): Remove tsserverlibrary from rollup globals #30123
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
This PR removes `tsserverlibrary` from rollup globals since the symbol should not appear by the time rollup is invoked. `tsserverlibrary` is used for types only, so the import statement should not be emitted by tsc.
vikerman
approved these changes
Apr 25, 2019
kyliau
added
action: merge
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…gular#30123) This PR removes `tsserverlibrary` from rollup globals since the symbol should not appear by the time rollup is invoked. `tsserverlibrary` is used for types only, so the import statement should not be emitted by tsc. PR Close angular#30123
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
tsserverlibraryfrom rollup globals since the symbolshould not appear by the time rollup is invoked.
tsserverlibraryisused for types only, so the import statement should not be emitted by
tsc.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information