Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(common): add upgrade sub-package to ng_package rule for @angular/common #30117

Closed
wants to merge 6 commits into from
Closed

build(common): add upgrade sub-package to ng_package rule for @angular/common #30117

wants to merge 6 commits into from

Conversation

brandonroberts
Copy link
Contributor

Follow-up to #30055 to include @angular/common/upgrade in the npm package

Closes #30116

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts brandonroberts requested a review from a team as a code owner April 25, 2019 14:43
@brandonroberts brandonroberts added area: common Issues related to APIs in the @angular/common package effort1: hours risk: low type: bug/fix labels Apr 25, 2019
@ngbot ngbot bot added this to the Backlog milestone Apr 25, 2019
@brandonroberts brandonroberts added the target: major This PR is targeted for the next major release label Apr 25, 2019
@brandonroberts brandonroberts modified the milestones: Backlog, version 8 Apr 25, 2019
@mary-poppins
Copy link

You can preview f5ab6be at https://pr30117-f5ab6be.ngbuilds.io/.

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Apr 25, 2019
@ngbot
Copy link

ngbot bot commented Apr 25, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_ivy_aot" is failing
    pending status "ci/angular: size" is pending
    pending status "ci/circleci: integration_test" is pending
    pending status "ci/circleci: legacy-unit-tests-saucelabs" is pending
    pending status "ci/circleci: material-unit-tests" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_aio" is pending
    pending status "ci/circleci: test_aio_local" is pending
    pending status "ci/circleci: test_aio_local_ivy" is pending
    pending status "ci/circleci: test_aio_preview" is pending
    pending status "ci/circleci: test_aio_tools" is pending
    pending status "ci/circleci: test_docs_examples" is pending
    pending status "ci/circleci: test_docs_examples_ivy" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@brandonroberts brandonroberts removed the action: merge The PR is ready for merge by the caretaker label Apr 25, 2019
@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker hotlist: release-blocker labels Apr 25, 2019
@mary-poppins
Copy link

You can preview 8261a5b at https://pr30117-8261a5b.ngbuilds.io/.

@brandonroberts brandonroberts requested a review from a team as a code owner April 25, 2019 18:27
@mary-poppins
Copy link

You can preview 92fba0f at https://pr30117-92fba0f.ngbuilds.io/.

@brandonroberts
fix(common): add upgrade sub-package to ng_package rule for @angular/…
be06739 
…common

Follow-up to angular#30055 to include @angular/common/upgrade in the npm package

Closes angular#30116
@mary-poppins
Copy link

You can preview be06739 at https://pr30117-be06739.ngbuilds.io/.

@brandonroberts brandonroberts requested a review from a team as a code owner April 25, 2019 20:00
@AndrewKushnir
Copy link
Contributor

Presubmit

@mary-poppins
Copy link

You can preview afab43e at https://pr30117-afab43e.ngbuilds.io/.

@jasonaden jasonaden self-assigned this Apr 25, 2019
@mary-poppins
Copy link

You can preview d0d355f at https://pr30117-d0d355f.ngbuilds.io/.

@brandonroberts brandonroberts requested a review from a team as a code owner April 25, 2019 21:15
@AndrewKushnir
Copy link
Contributor

Presubmit #2

@mary-poppins
Copy link

You can preview dbdb0c1 at https://pr30117-dbdb0c1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ae87305 at https://pr30117-ae87305.ngbuilds.io/.

@alexeagle
Copy link
Contributor

presubmit

@mary-poppins
Copy link

You can preview f3a8c1b at https://pr30117-f3a8c1b.ngbuilds.io/.

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@brandonroberts @BioPhoton
fix(common): add upgrade sub-package to ng_package rule for @angular/…
b815e36 
…common (angular#30117)

Follow-up to angular#30055 to include @angular/common/upgrade in the npm package

Closes angular#30116

PR Close angular#30117
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@jasonaden jasonaden jasonaden approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes effort1: hours risk: low target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
version 8
Development

Successfully merging this pull request may close these issues.

Build: @angular/common/upgrade is not included in the package build
7 participants
@brandonroberts @mary-poppins @AndrewKushnir @alexeagle @IgorMinar @jasonaden @googlebot