Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): make name param in ng add optional #30074

Closed
wants to merge 1 commit into from
Closed

fix(bazel): make name param in ng add optional #30074

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 23, 2019 •
edited

ng add should infer project name from defaultProject if none is provided.

PR closes #29572

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Apr 23, 2019
@kyliau kyliau requested a review from a team as a code owner April 23, 2019 21:59
@ngbot ngbot bot added this to the needsTriage milestone Apr 23, 2019
@kyliau kyliau requested a review from alexeagle April 23, 2019 22:01
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Apr 24, 2019
@kyliau kyliau deleted the ngadd branch April 24, 2019 22:23
@kyliau kyliau mentioned this pull request Apr 24, 2019
Closed
@kyliau kyliau mentioned this pull request May 9, 2019
Closed
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@kyliau @BioPhoton
fix(bazel): make name param in ng add optional (angular#30074)
0f351f3 
PR Close angular#30074
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

@angular/bazel's schematics property should be project not name
3 participants
@kyliau @alexeagle @googlebot