Skip to content

fix(bazel): transitive npm deps in ng_module #30065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): transitive npm deps in ng_module #30065

wants to merge 1 commit into from
+9 −4

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Apr 23, 2019 •
edited
Loading

BREAKING CHANGE: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12.

Equivalent change to ng_module that was made to ts_library in bazel-contrib/rules_nodejs#675.

This fixes the issue reported by @mattem and reproducible here https://github.com/mattem/ng_transitive_deps_eg

If a transitive npm dep such as @npm//moment-timezone is missing which is not used directly by any files compiled in an ng_module but is used transitively by a dep like //service,

ng_module(
    name = "component",
    srcs = glob(["*.ts"]),
    deps = [
        "//service",
        "@npm//@angular/core",
        "@npm//@angular/common",
        # "@npm//moment-timezone",
    ],
    visibility = ["//:__subpackages__"],
    tsconfig = "//:tsconfig",
)

this can lead to the isSkipSelf error which is not helpful at all:

ERROR: /Users/greg/google/gregmagolan/ng_transitive_deps_eg/component/BUILD:3:1: Compiling Angular templates (ngc) //component:component failed (Exit 1) ngc-wrapped__bin failed: error executing command bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin '--node_options=--expose-gc' '--node_options=--stack-trace-limit=100' '--node_options=--max-old-space-size=2048' ... (remaining 1 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
: TypeError: Cannot read property 'isSkipSelf' of null
    at ProviderElementContext._getDependency (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20171:22)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20116:64
    at Array.map (<anonymous>)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20116:30
    at Array.map (<anonymous>)
    at ProviderElementContext._getOrCreateLocalProvider (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:20094:67)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:19992:27
    at Array.forEach (<anonymous>)
    at new ProviderElementContext (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:19989:53)
    at TemplateParseVisitor.visitElement (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21476:35)
    at Element.visit (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10673:80)
    at visit (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10689:41)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10691:29
    at Array.forEach (<anonymous>)
    at visitAll$1 (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:10690:15)
    at TemplateParser.tryParseHtml (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21329:26)
    at TemplateParser.tryParse (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21310:25)
    at TemplateParser.parse (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:21288:31)
    at AotCompiler._parseTemplate (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24803:47)
    at AotCompiler._createTypeCheckBlock (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24550:27)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24518:31
    at Array.forEach (<anonymous>)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24512:53
    at Array.forEach (<anonymous>)
    at AotCompiler._createNgFactoryStub (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24491:28)
    at AotCompiler.emitTypeCheckStub (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler/bundles/compiler.umd.js:24459:22)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:655:54
    at Array.forEach (<anonymous>)
    at AngularCompilerProgram._updateProgramWithTypeCheckStubs (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:649:41)
    at AngularCompilerProgram.initSync (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:582:22)
    at AngularCompilerProgram.get [as tsProgram] (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:514:26)
    at AngularCompilerProgram.getTsProgram (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/transformers/program.js:147:83)
    at gatherDiagnosticsForInputsOnly (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:408:37)
    at gatherDiagnostics (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:340:46)
    at Object.performCompilation (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/compiler-cli/src/perform_compile.js:213:72)
    at compile (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:342:57)
    at runOneBuild (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:116:33)
    at main (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:39:20)
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:432:28
    at /private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:10:17
    at Object.<anonymous> (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/sandbox/darwin-sandbox/2/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin.runfiles/npm/node_modules/@angular/bazel/src/ngc-wrapped/index.js:16:3)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Object.<anonymous> (/private/var/tmp/_bazel_greg/d2c57935f6122ffd071eacd6aaf609f9/execroot/sandbox/bazel-out/host/bin/external/npm/node_modules/@angular/bazel/ngc-wrapped__bin_bin_loader.js:489:24)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)
    at startup (internal/bootstrap/node.js:285:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)

INFO: Elapsed time: 76.755s, Critical Path: 25.71s
INFO: 1 process: 1 darwin-sandbox.
FAILED: Build did NOT complete successfully

@gregmagolan gregmagolan requested a review from alexeagle April 23, 2019 17:54
@gregmagolan gregmagolan requested a review from a team as a code owner April 23, 2019 17:54
@gregmagolan gregmagolan added the area: bazel Issues related to the published `@angular/bazel` build rules label Apr 23, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 23, 2019
@gregmagolan gregmagolan added the target: major This PR is targeted for the next major release label Apr 23, 2019
@gregmagolan
fix(bazel): transitive npm deps in ng_module
dac5fca 
BREAKING CHANGE:

ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12
@gregmagolan gregmagolan force-pushed the ng-module-transitive-npm-deps branch from 8fcfe41 to dac5fca Compare April 23, 2019 17:56
@alexeagle alexeagle added hotlist: release-blocker action: merge The PR is ready for merge by the caretaker labels Apr 23, 2019
@benlesh benlesh added the action: presubmit The PR is in need of a google3 presubmit label Apr 23, 2019
@benlesh
Copy link
Contributor

benlesh commented Apr 23, 2019

@alexeagle This PR is bombing before TAP even starts in google3: https://critique.corp.google.com/#review/244931913

@benlesh benlesh added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 23, 2019
@IgorMinar IgorMinar modified the milestones: needsTriage, version 8 Apr 24, 2019
@AndrewKushnir
Copy link
Contributor

Removing "release blocker" label from this PR after a quick chat with Alex Eagle.

@alexeagle alexeagle added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 25, 2019
@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Apr 25, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@gregmagolan @BioPhoton
fix(bazel): transitive npm deps in ng_module (angular#30065)
e7ad876 
BREAKING CHANGE:

ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12

PR Close angular#30065
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
version 8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gregmagolan @benlesh @AndrewKushnir @alexeagle @IgorMinar @googlebot