Skip to content

fix(bazel): restore ng build --prod #30005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): restore ng build --prod #30005

wants to merge 1 commit into from
+6 −1

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 20, 2019

ng build by default builds the prodapp because there is not
a dev build in Bazel. This PR restores the --prod to do the
same to prevent achitect from showing missing config error.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@kyliau
fix(bazel): restore ng build --prod
17770ea 
`ng build` by default builds the prodapp because there is not
a dev build in Bazel. This PR restores the `--prod` to do the
same to prevent achitect from showing missing config error.
@kyliau kyliau added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Apr 20, 2019
@kyliau kyliau requested a review from a team as a code owner April 20, 2019 17:44
@ngbot ngbot bot added this to the needsTriage milestone Apr 20, 2019
@kyliau kyliau requested a review from alexeagle April 20, 2019 17:45
mgechev
mgechev approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. In general, we should consider producing a production build by default. Since this would be a breaking change, we should plan it for v9 though.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Apr 22, 2019
@benlesh benlesh closed this in 96a8289 Apr 22, 2019
@kyliau kyliau deleted the build branch April 22, 2019 16:55
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@kyliau @BioPhoton
fix(bazel): restore ng build --prod (angular#30005)
ee801c4 
`ng build` by default builds the prodapp because there is not
a dev build in Bazel. This PR restores the `--prod` to do the
same to prevent achitect from showing missing config error.

PR Close angular#30005
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle

@mgechev mgechev

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @alexeagle @mgechev @googlebot