fix(core): use shakeable global definitions #29929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview bb7b732 at https://pr29929-bb7b732.ngbuilds.io/. |
The `ngDevMode` and `ngI18nClosureMode` are special in that they should be set to `false` on production builds in order to shake out code associated with it. Angular CLI does this in https://github.com/angular/angular-cli/blob/5fc1f2499cbe57f9a95e4b0dfced130eb3a8046d/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L279-L282. But in angular#28689 the toplevel usage was changed from `ngDevMode` to `global['ngDevMode']` (and the same for `ngI18nClosureMode`). This indirection prevents the static analysis in Terser from effecting the replacement.
filipesilva
force-pushed
the
fix-globaldefs
branch
from
bb7b732
to
b44260f
Compare
|
You can preview b44260f at https://pr29929-b44260f.ngbuilds.io/. |
raducostea
approved these changes
Apr 16, 2019
filipesilva
added
the
action: review
|
You can preview c194b32 at https://pr29929-c194b32.ngbuilds.io/. |
alexeagle
approved these changes
Apr 17, 2019
alexeagle
added
action: merge
filipesilva
requested review from
vikerman
and removed request for
mhevery and
ocombe
benlesh
pushed a commit
that referenced
this pull request
Apr 18, 2019
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Apr 24, 2019
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Apr 24, 2019
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Apr 24, 2019
alexeagle
pushed a commit
to angular/angular-cli
that referenced
this pull request
Apr 24, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
The `ngDevMode` and `ngI18nClosureMode` are special in that they should be set to `false` on production builds in order to shake out code associated with it. Angular CLI does this in https://github.com/angular/angular-cli/blob/5fc1f2499cbe57f9a95e4b0dfced130eb3a8046d/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L279-L282. But in angular#28689 the toplevel usage was changed from `ngDevMode` to `global['ngDevMode']` (and the same for `ngI18nClosureMode`). This indirection prevents the static analysis in Terser from effecting the replacement. PR Close angular#29929
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ngDevModeandngI18nClosureModeare special in that they should be set tofalseon production builds in order to shake out code associated with it.Angular CLI does this in https://github.com/angular/angular-cli/blob/5fc1f2499cbe57f9a95e4b0dfced130eb3a8046d/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L279-L282.
But in #28689 the toplevel usage was changed from
ngDevModetoglobal['ngDevMode'](and the same forngI18nClosureMode). This indirection prevents the static analysis in Terser from effecting the replacement.What is the new behavior?
The variables that should be defined globally are synced between Angular core and CLI.
Does this PR introduce a breaking change?
Other information