Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): resolve ts compile issues due to lenient tsconfig #29843

Closed
wants to merge 1 commit into from
Closed

fix(core): resolve ts compile issues due to lenient tsconfig #29843

wants to merge 1 commit into from

Conversation

IgorMinar
Copy link
Contributor

The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.

@IgorMinar
fix(core): resolve ts compile issues due to lenient tsconfig
4bf917b 
The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.
@IgorMinar IgorMinar requested a review from a team as a code owner April 11, 2019 17:49
@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 11, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 11, 2019
@mary-poppins
Copy link

You can preview 4bf917b at https://pr29843-4bf917b.ngbuilds.io/.

@IgorMinar IgorMinar closed this in 54058ba Apr 11, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@IgorMinar @wKoza
fix(core): resolve ts compile issues due to lenient tsconfig (angular…
abdf367 
…#29843)

The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.

PR Close angular#29843
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IgorMinar @mary-poppins @gkalpak @googlebot