Enable all Angular Bazel Tests on Windows #29785

meteorcloudy · 2019-04-09T13:31:03Z

🐞 bug report

Is this a regression?

Nope

Description

Angular tests are only partially enabled on Windows:

Lines 22 to 24 in 1102b02

    
           # Run tests 
        
           - yarn bazel test //tools/ts-api-guardian:all 
        
           - yarn test-ivy-aot //packages/animations/test //packages/common/test //packages/forms/test //packages/http/test //packages/platform-browser/test //packages/platform-browser-dynamic/test //packages/router/test

To have better Windows support, we should be able to run all tests on Windows, that is:

bazel test //... --build_tag_filters=-ivy-only --test_tag_filters=-ivy-only
yarn test-ivy-aot //...

(IIUC, yarn test-ivy-aot //... is essentially bazel test --define=compile=aot --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot --test_tag_filters=-no-ivy-aot,-fixme-ivy-aot //...)

I tried to run all tests without ivy-only with Bazel 0.24.1 and got

Executed 102 out of 175 tests: 86 tests pass, 72 fail to build and 17 fail locally.

See full detail at Angular test with Bazel 0.24.1

It turned out all broken tests are because powershell.exe is not available when using --incompatible_strict_action_env. So I sent a change in Bazel to fix this problem. bazelbuild/bazel@6e75219

With Bazel@6e75219, after working around some incompatibility issues, I'm able to build and run all Angular tests on Windows. The results are:

Angular tests with Bazel@6e75219, excluding ivy-only

Executed 175 out of 175 tests: 152 tests pass and 23 fail locally.

Angular tests with Bazel@6e75219, ivy-only

Executed 7 out of 147 tests: 140 tests pass and 7 fail locally.

Current TODO list is:

Wait for a Bazel release that contains bazelbuild/bazel@6e75219, should be 0.26 (Do you prefer this to be cherry-pick into 0.25, so that we can have it this month?)
Fix incompatibility issues:
1. build: Fix label name #29777
2. bazel-0.24.1 build --nobuild //... --incompatible_bzl_disallow_load_after_statement
3. Wait for a fix (Fix config_setting for msvc google/brotli#748) for brotli, then update org_brotli
Look into failing tests with Bazel@6e75219, will provide a way to reproduce.

🔬 Minimal Reproduction

# Get Bazel binary built at 6e752195f0b0c6d67822368b82c990dff168a258
wget https://storage.googleapis.com/bazel-builds/artifacts/windows/6e752195f0b0c6d67822368b82c990dff168a258/bazel -O <your preferred Bazel path (with .exe extension)>

# Cherry-pick https://github.com/angular/angular/pull/29777 if it's still not merged.

# Run tests except ivy-only
bazel test //... --build_tag_filters=-ivy-only --test_tag_filters=-ivy-only --incompatible_bzl_disallow_load_after_statement=false

# Run ivy-only tests 
bazel test //... --define=compile=aot --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot --test_tag_filters=-no-ivy-aot,-fixme-ivy-aot --incompatible_bzl_disallow_load_after_statement=false

Note that we still need --incompatible_bzl_disallow_load_after_statement=false until the incompatibility issue is fixed.

If you failed to build brotli, you can use the following in packages/bazel/package.bzl:

    http_archive(
        name = "org_brotli",
        sha256 = "44ebae3308fd1a757fdc4891e1e1e61ab964afb223ba298d2ea0c29a49564f53",
        strip_prefix = "brotli-7388ebb113f0e1dbf4ab0f2daddf036abf29b8e6",
        url = "https://github.com/meteorcloudy/brotli/archive/7388ebb113f0e1dbf4ab0f2daddf036abf29b8e6.zip",
    )

🌍 Your Environment

Angular Version:


ec5635430630fb895ddb43017f9939564824e8f8

@alexeagle @filipesilva Can you point this issue to correct people in Angular Windows team? I will also continue to help investigating.

The text was updated successfully, but these errors were encountered:

meteorcloudy · 2019-04-10T09:26:10Z

Tests to be fixed:

--build_tag_filters=-ivy-only --test_tag_filters=-ivy-only:

--define=compile=aot --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot --test_tag_filters=-no-ivy-aot,-fixme-ivy-aot

//modules/playground/e2e_test/sourcemap:protractor_tests_chromium-local FAILED in 13.5s
//packages/bazel/test/ngc-wrapped:ngc_test FAILED in 4.8s
//packages/bazel/test/protractor-2:prodserver_test_chromium-local FAILED in 9.6s
//packages/compiler-cli/ngcc/test:test FAILED in 9.0s
//packages/compiler-cli/test/compliance:compliance FAILED in 76.0s
//packages/compiler-cli/test/ngtsc:ngtsc FAILED in 96.6s
//tools/ts-api-guardian:tests FAILED in 11.4s

alexeagle · 2019-04-10T15:30:13Z

note, we can publish nightly snapshots of Bazel to npm, so we don't necessarily need to wait for fixes to be released. I started this in https://github.com/alexeagle/rules_nodejs/tree/nightly_bazel but need some help to finish probably

This change addresses several issues with ts-api-guardian and public api guards related tests in Windows The fixes contain 3 main changes: 1) In `stripExportPattern` - replace `^` with `^^^^` in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js. 2. Force `*.patch` files to always be with a LF line sequence instead of CRLF in windows 3. When adding JSDoc comments consider the presence of a carriage return in a line new feed Partially addresses #29785 PR Close #30105

This PR parially addresses #29785 and fixes ` //packages/language-service/test:test` PR Close #30113

Partially addresses #29785 PR Close #30111

s-gbz · 2019-05-07T09:44:01Z

Just to clarify: Is there a workaround to have the tests run on Windows successfully?
I faced a similiar issue in #30251 and #30252 😞

meteorcloudy · 2019-05-07T10:05:35Z

#30252 will be fixed by bazelbuild/bazel@6e75219, which will be released with 0.26.0

I can help look into #30251, this looks like a bug instead of a real performance issue.

``` //packages/compiler-cli/integrationtest:integrationtest //packages/compiler-cli/test/compliance:compliance ``` Partially addresses #29785 PR Close #30189

Under Windows, the server binary has an extension of `.exe` and the current logic is not handling that. Partially addresses: #29785 PR Close #30346

``` //packages/compiler-cli/test:ngc //packages/compiler/test:test ``` This also address `node_modules` to the ignored paths for ngc compiler as otherwise the `ready` is never fired Partially addresses #29785 PR Close #30146

``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses #29785 PR Close #30297

``` //packages/compiler-cli/ngcc/test:integration ``` Partially addresses #29785 PR Close #30297

…30105) This change addresses several issues with ts-api-guardian and public api guards related tests in Windows The fixes contain 3 main changes: 1) In `stripExportPattern` - replace `^` with `^^^^` in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js. 2. Force `*.patch` files to always be with a LF line sequence instead of CRLF in windows 3. When adding JSDoc comments consider the presence of a carriage return in a line new feed Partially addresses angular#29785 PR Close angular#30105

This PR parially addresses angular#29785 and fixes ` //packages/language-service/test:test` PR Close angular#30113

Partially addresses angular#29785 PR Close angular#30111

``` //packages/compiler-cli/integrationtest:integrationtest //packages/compiler-cli/test/compliance:compliance ``` Partially addresses angular#29785 PR Close angular#30189

…#30346) Under Windows, the server binary has an extension of `.exe` and the current logic is not handling that. Partially addresses: angular#29785 PR Close angular#30346

``` //packages/compiler-cli/test:ngc //packages/compiler/test:test ``` This also address `node_modules` to the ignored paths for ngc compiler as otherwise the `ready` is never fired Partially addresses angular#29785 PR Close angular#30146

``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses angular#29785 PR Close angular#30297

``` //packages/compiler-cli/ngcc/test:integration ``` Partially addresses angular#29785 PR Close angular#30297

JoostK added the area: bazel Issues related to the published `@angular/bazel` build rules label Apr 9, 2019

ngbot bot added this to the needsTriage milestone Apr 9, 2019

pkozlowski-opensource added the area: build & ci Related the build and CI infrastructure of the project label Apr 10, 2019

alexeagle added freq2: medium hotlist: windows-support type: bug/fix labels Apr 24, 2019

ngbot bot modified the milestones: needsTriage, Backlog Apr 24, 2019

AndrewKushnir pushed a commit that referenced this issue Apr 26, 2019

test: fix language service tests in windows (#30113)

e4b81a6

This PR parially addresses #29785 and fixes ` //packages/language-service/test:test` PR Close #30113

AndrewKushnir pushed a commit that referenced this issue Apr 26, 2019

test: fix language service tests in windows (#30113)

d896126

This PR parially addresses #29785 and fixes ` //packages/language-service/test:test` PR Close #30113

alan-agius4 mentioned this issue Apr 29, 2019

test: fix several bazel compiler-cli tests in windows #30189

Closed

AndrewKushnir pushed a commit that referenced this issue Apr 29, 2019

test: fix ngc-wrapped bazel tests in windows (#30111)

6701250

Partially addresses #29785 PR Close #30111

AndrewKushnir pushed a commit that referenced this issue Apr 29, 2019

test: fix ngc-wrapped bazel tests in windows (#30111)

21418ea

Partially addresses #29785 PR Close #30111

alan-agius4 mentioned this issue Apr 30, 2019

Windows ngcc infinite loop #30212

Closed

kara mentioned this issue May 6, 2019

Contributing: Bazel test execution fails #30252

Closed

alan-agius4 mentioned this issue May 7, 2019

Windows ngcc infinite loop and tests under windows #30297

Closed

kara pushed a commit that referenced this issue May 7, 2019

test: fix several bazel compiler-cli tests in windows (#30189)

c1f3faf

``` //packages/compiler-cli/integrationtest:integrationtest //packages/compiler-cli/test/compliance:compliance ``` Partially addresses #29785 PR Close #30189

kara pushed a commit that referenced this issue May 7, 2019

test: fix several bazel compiler-cli tests in windows (#30189)

1660b34

``` //packages/compiler-cli/integrationtest:integrationtest //packages/compiler-cli/test/compliance:compliance ``` Partially addresses #29785 PR Close #30189

alan-agius4 mentioned this issue May 9, 2019

fix(bazel): pass correct arguments to http_server in Windows #30346

Closed

alxhub pushed a commit that referenced this issue May 9, 2019

fix(bazel): pass correct arguments to http_server in Windows (#30346)

71eba45

Under Windows, the server binary has an extension of `.exe` and the current logic is not handling that. Partially addresses: #29785 PR Close #30346

alxhub pushed a commit that referenced this issue May 9, 2019

fix(bazel): pass correct arguments to http_server in Windows (#30346)

3aff79c

Under Windows, the server binary has an extension of `.exe` and the current logic is not handling that. Partially addresses: #29785 PR Close #30346

filipesilva mentioned this issue May 10, 2019

Update bazel #30370

Closed

alxhub pushed a commit that referenced this issue May 13, 2019

test: fix ngcc unit tests in windows (#30297)

1bd4891

``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses #29785 PR Close #30297

alxhub pushed a commit that referenced this issue May 13, 2019

test: fix ngcc integration tests in windows (#30297)

18c0ba5

``` //packages/compiler-cli/ngcc/test:integration ``` Partially addresses #29785 PR Close #30297

BioPhoton pushed a commit to BioPhoton/angular that referenced this issue May 21, 2019

test: fix language service tests in windows (angular#30113)

f3af01d

This PR parially addresses angular#29785 and fixes ` //packages/language-service/test:test` PR Close angular#30113

BioPhoton pushed a commit to BioPhoton/angular that referenced this issue May 21, 2019

test: fix ngc-wrapped bazel tests in windows (angular#30111)

9cbce90

Partially addresses angular#29785 PR Close angular#30111

BioPhoton pushed a commit to BioPhoton/angular that referenced this issue May 21, 2019

test: fix ngcc unit tests in windows (angular#30297)

4e13263

``` //packages/compiler-cli/ngcc/test:test ``` Partially addresses angular#29785 PR Close angular#30297

BioPhoton pushed a commit to BioPhoton/angular that referenced this issue May 21, 2019

test: fix ngcc integration tests in windows (angular#30297)

3d7015f

``` //packages/compiler-cli/ngcc/test:integration ``` Partially addresses angular#29785 PR Close angular#30297

iget-master mentioned this issue Jul 10, 2019

CHANGELOG.md shouldn't include pre-release changes? #31491

Closed

AndrewKushnir added the windows Issue related to Microsoft's Windows operating system label May 18, 2020

pkozlowski-opensource removed the hotlist: windows-support label May 19, 2020

jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed severity3: broken labels Oct 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable all Angular Bazel Tests on Windows #29785

Enable all Angular Bazel Tests on Windows #29785

meteorcloudy commented Apr 9, 2019 •

edited

meteorcloudy commented Apr 10, 2019 •

edited by alan-agius4

alexeagle commented Apr 10, 2019

s-gbz commented May 7, 2019 •

edited

meteorcloudy commented May 7, 2019

Enable all Angular Bazel Tests on Windows #29785

Enable all Angular Bazel Tests on Windows #29785

Comments

meteorcloudy commented Apr 9, 2019 • edited

🐞 bug report

Is this a regression?

Description

🔬 Minimal Reproduction

🌍 Your Environment

meteorcloudy commented Apr 10, 2019 • edited by alan-agius4

alexeagle commented Apr 10, 2019

s-gbz commented May 7, 2019 • edited

meteorcloudy commented May 7, 2019

meteorcloudy commented Apr 9, 2019 •

edited

meteorcloudy commented Apr 10, 2019 •

edited by alan-agius4

s-gbz commented May 7, 2019 •

edited