Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel builder #29720

Closed
wants to merge 2 commits into from
Closed

Update bazel builder #29720

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 5, 2019

build: update angular cli packages to latest beta

feat(bazel): update the build to use the new architect api
With this change the builder has been updated to use the latest architect API and make it compatible with the latest CLI

Fixes angular/angular-cli#14082

refactor: use standard node resolution methods where possible
This aligns with the CLI as we'd like to use standard node resolutions when possible angular/angular-cli#14029

This also makes the builder run on windows

@alan-agius4 alan-agius4 added area: bazel Issues related to the published `@angular/bazel` build rules target: major This PR is targeted for the next major release labels Apr 5, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 5, 2019
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Apr 5, 2019

@kyliau there seems to be a problem, because @bazel/karma still uses karma-jasmine 1 while in the workspace we uses version 2.

The same thing applies for jasmine-core

test is throwing an error No provider for "framework:jasmine"!

@alan-agius4 alan-agius4 marked this pull request as ready for review April 5, 2019 11:50
@alan-agius4 alan-agius4 requested review from a team as code owners April 5, 2019 11:50
integration/bazel-schematics/package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
packages/bazel/src/builders/bazel.ts Show resolved Hide resolved
@kyliau
Copy link
Contributor

kyliau commented Apr 6, 2019

@alan-agius4 CI is green

With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Apr 6, 2019
@alan-agius4
Copy link
Contributor Author

Thanks @kyliau for your help

@IgorMinar IgorMinar closed this in e381155 Apr 8, 2019
IgorMinar pushed a commit that referenced this pull request Apr 8, 2019
With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

PR Close #29720
@alan-agius4 alan-agius4 deleted the bazel-builder branch April 8, 2019 18:39
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
…9720)

With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

PR Close angular#29720
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
…9720)

With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

PR Close angular#29720
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng serve failed on Error: Could not find the implementation for builder @angular/bazel:build
4 participants