Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nodejs rules 0.27.10 #29694

Closed

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Apr 4, 2019

Also,

  • adds configuration_env_vars = ["compile"] to generated @npm//@angular/bazel/bin:ngc-wrapped nodejs_binary using new bazelBin additionalAttributes yarn_install & npm_install feature. This is required to be able to compile with Ivy using ng_module by setting build --define=compile=aot in .bazelrc.

  • /integration/bazel: removes umd, ngfactory & ngsummary scripts that no longer need to be explicitly specified in ts_devserver & ts_web_test_suite in

@gregmagolan gregmagolan requested review from a team as code owners April 4, 2019 00:00
@gregmagolan gregmagolan added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Apr 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 4, 2019
@gregmagolan
Copy link
Contributor Author

Generated ngc-wrapped binary target in /integration/bazel now looks like this:

# Wire up the `bin` entry `ngc-wrapped`
nodejs_binary(
    name = "ngc-wrapped__bin",
    entry_point = "@angular/bazel/src/ngc-wrapped/index.js",
    install_source_map_support = False,
    data = [":bazel__pkg"],
    configuration_env_vars = ["compile"],
)

with the added configuration_env_vars attribute.

Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregmagolan
Copy link
Contributor Author

Please also remove the scripts from https://github.com/angular/angular/blob/master/packages/bazel/src/builders/files/src/BUILD.bazel.template

Done. Good catch.

@alexeagle
Copy link
Contributor

alexeagle commented Apr 4, 2019

CI failure looks legit:

HeadlessChrome 69.0.3497 (Linux 0.0.0) ERROR: 'There is no timestamp for tslib.js!'

04 04 2019 02:17:04.392:WARN [web-server]: 404: /tslib.js
HeadlessChrome 69.0.3497 (Linux 0.0.0) ERROR
  {
    "message": "Uncaught Error: Script error for \"tslib\", needed by: project/src/app/app.component, project/src/app/widget/widget.component

My guess is that something has importHelpers: true in tsconfig, which is fine, and then deps on tslib, but we are missing the third-party-lib getting included in devSources still.

@gregmagolan gregmagolan force-pushed the build/nodejs-rules-0.27.10 branch 2 times, most recently from 12a5062 to bdd7037 Compare April 4, 2019 16:14
@gregmagolan
Copy link
Contributor Author

My guess is that something has importHelpers: true in tsconfig, which is fine, and then deps on tslib, but we are missing the third-party-lib getting included in devSources still.

Seems like. I added tslib back to ts_devserver & ts_web_test_suite here. We can fix this is another PR.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Apr 4, 2019
@IgorMinar IgorMinar closed this in 7fbe138 Apr 4, 2019
IgorMinar pushed a commit that referenced this pull request Apr 4, 2019
…m//@angular/bazel/bin:ngc-wrapped nodejs_binary (#29694)

PR Close #29694
IgorMinar pushed a commit that referenced this pull request Apr 4, 2019
IgorMinar pushed a commit that referenced this pull request Apr 4, 2019
IgorMinar pushed a commit that referenced this pull request Apr 4, 2019
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants