-
Notifications
You must be signed in to change notification settings - Fork 26.2k
Update to nodejs rules 0.27.10 #29694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to nodejs rules 0.27.10 #29694
Conversation
…m//@angular/bazel/bin:ngc-wrapped nodejs_binary
Generated ngc-wrapped binary target in
with the added |
…est_suite in /integration/bazel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the scripts from https://github.com/angular/angular/blob/master/packages/bazel/src/builders/files/src/BUILD.bazel.template
…est_suite in bazel schematics
Done. Good catch. |
CI failure looks legit:
My guess is that something has |
12a5062
to
bdd7037
Compare
…uite for schematics
bdd7037
to
3c57d1f
Compare
Seems like. I added tslib back to ts_devserver & ts_web_test_suite here. We can fix this is another PR. |
…m//@angular/bazel/bin:ngc-wrapped nodejs_binary (angular#29694) PR Close angular#29694
…est_suite in /integration/bazel (angular#29694) PR Close angular#29694
…m//@angular/bazel/bin:ngc-wrapped nodejs_binary (angular#29694) PR Close angular#29694
…est_suite in /integration/bazel (angular#29694) PR Close angular#29694
…est_suite in bazel schematics (angular#29694) PR Close angular#29694
…uite for schematics (angular#29694) PR Close angular#29694
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Also,
adds
configuration_env_vars = ["compile"]
togenerated @npm//@angular/bazel/bin:ngc-wrapped
nodejs_binary using newbazelBin
additionalAttributes
yarn_install & npm_install feature. This is required to be able to compile with Ivy using ng_module by settingbuild --define=compile=aot
in.bazelrc
./integration/bazel: removes umd, ngfactory & ngsummary scripts that no longer need to be explicitly specified in ts_devserver & ts_web_test_suite in