Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): support running ng-add on minimal applications #29681

Closed
wants to merge 1 commit into from
Closed

fix(bazel): support running ng-add on minimal applications #29681

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

Minimal applications don't have test and e2e targets but we are not currently checking if they exists.

Fixes #29680

@alan-agius4 alan-agius4 requested a review from a team as a code owner April 3, 2019 12:52
@alan-agius4
fix(bazel): support running ng-add on minimal applications
6046f28 
Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.

Fixes #29680
@alan-agius4 alan-agius4 added area: bazel Issues related to the published `@angular/bazel` build rules target: major This PR is targeted for the next major release labels Apr 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 3, 2019
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Apr 3, 2019
@jasonaden jasonaden closed this in 9810c6c Apr 3, 2019
@alan-agius4 alan-agius4 deleted the ng-add-bazel branch April 4, 2019 05:25
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@alan-agius4 @DeveloperFromUkraine
fix(bazel): support running ng-add on minimal applications (angular#2…
08b6158 
…9681)

Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.

Fixes angular#29680

PR Close angular#29681
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@alan-agius4 @wKoza
fix(bazel): support running ng-add on minimal applications (angular#2…
dfaa436 
…9681)

Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.

Fixes angular#29680

PR Close angular#29681
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@kyliau kyliau kyliau approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Property e2e does not exist in JSON object after ng add @angular/bazel
4 participants
@alan-agius4 @alexeagle @kyliau @googlebot