Skip to content

fix(bazel): use //:tsconfig.json as the default for ng_module #29670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): use //:tsconfig.json as the default for ng_module #29670

wants to merge 1 commit into from
+30 −13

Conversation

alexeagle
Copy link
Contributor

This matches the behavior of ts_library

@alexeagle alexeagle requested a review from kyliau April 2, 2019 18:44
@alexeagle alexeagle requested a review from a team as a code owner April 2, 2019 18:44
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 2, 2019
@alexeagle
fix(bazel): use //:tsconfig.json as the default for ng_module

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
235128f 
This matches the behavior of ts_library
@alexeagle alexeagle requested a review from a team as a code owner April 2, 2019 19:15
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 2, 2019
@jasonaden jasonaden added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 2, 2019
@jasonaden jasonaden closed this in b14537a Apr 2, 2019
alexeagle added a commit to alexeagle/angular that referenced this pull request Apr 4, 2019
@alexeagle
fix(bazel): use //:tsconfig.json as the default for ng_module (angula…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
81667d0 
…r#29670)

This matches the behavior of ts_library

PR Close angular#29670
@alexeagle alexeagle mentioned this pull request Apr 4, 2019
Closed
jasonaden pushed a commit that referenced this pull request Apr 4, 2019
@alexeagle @jasonaden
fix(bazel): use //:tsconfig.json as the default for ng_module (#29670) (

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9e33dc3 
#29711)

This matches the behavior of ts_library

PR Close #29670

PR Close #29711
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019
@alexeagle @DeveloperFromUkraine
fix(bazel): use //:tsconfig.json as the default for ng_module (angula…

Verified

This commit was signed with the committer’s verified signature.
dvic Damir Vandic
GPG key ID: FF6528EC6B2AA032
Verified
Learn about vigilant mode
3e57579 
…r#29670)

This matches the behavior of ts_library

PR Close angular#29670
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@alexeagle @wKoza
fix(bazel): use //:tsconfig.json as the default for ng_module (angula…

Verified

This commit was signed with the committer’s verified signature.
dvic Damir Vandic
GPG key ID: FF6528EC6B2AA032
Verified
Learn about vigilant mode
a5c1c4b 
…r#29670)

This matches the behavior of ts_library

PR Close angular#29670
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @kyliau @jasonaden @googlebot