fix(compiler-cli): ensure LogicalProjectPaths always start with a slash #29627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
type: bug/fix
action: merge
gkalpak
approved these changes
Apr 1, 2019
alxhub
requested changes
Apr 2, 2019
alxhub
approved these changes
Apr 4, 2019
petebacondarwin
force-pushed
the
ngtsc-logical-path-fix
branch
2 times, most recently
from
68532cc
to
b7f48a7
Compare
Previously, if a matching rootDir ended with a slash then the path returned from `logicalPathOfFile()` would not start with a slash, which is inconsistent.
petebacondarwin
force-pushed
the
ngtsc-logical-path-fix
branch
from
b7f48a7
to
93df013
Compare
DeveloperFromUkraine
pushed a commit
to DeveloperFromUkraine/angular
that referenced
this pull request
Apr 11, 2019
…sh (angular#29627) Previously, if a matching rootDir ended with a slash then the path returned from `logicalPathOfFile()` would not start with a slash, which is inconsistent. PR Close angular#29627
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…sh (angular#29627) Previously, if a matching rootDir ended with a slash then the path returned from `logicalPathOfFile()` would not start with a slash, which is inconsistent. PR Close angular#29627
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a matching rootDir ended with a slash then the path
returned from
logicalPathOfFile()would not start with a slash,which is inconsistent.