feat(core): create template-var-assignment update schematic #29608
Conversation
devversion
added
action: review
Introduces a new update schematic called "template-var-assignment" that is responsible for analyzing template files in order to warn developers if template variables are assigned to values. The schematic also comes with a driver for `tslint` so that the check can be used wtihin Google.
devversion
force-pushed
the
feat/core-template-local-vars-migration
branch
from
6f48759 to
9eb1e4e
Compare
There was a problem hiding this comment.
Thanks @devversion. Everything looks great, you've covered the most frequently used patterns and also thanks for the ts rule - it'd be super helpful to avoid these patterns in the future 👍
| srcs = glob(["**/*.ts"]), | ||
| tsconfig = "//packages/core/schematics:tsconfig.json", | ||
| visibility = [ | ||
| "//packages/core/schematics:__pkg__", |
There was a problem hiding this comment.
nit: maybe you just want //packages/core/schematics:__subpackages__
There was a problem hiding this comment.
I'd prefer being explicit as this means that we always need to make sure which packages us another Bazel package.
| export class Rule extends Rules.TypedRule { | ||
| applyWithProgram(sourceFile: ts.SourceFile, program: ts.Program): RuleFailure[] { | ||
| const typeChecker = program.getTypeChecker(); | ||
| const templateVisitor = new NgComponentTemplateVisitor(typeChecker); |
There was a problem hiding this comment.
we've never run a codelyzer rule in google3. I suspect it won't work because tsunami operates over a TS compilation capture and the angular templates are probably not available. If we need to do this cleanup in google3 someone will probably have to fix that, might be a big design change but I'm not sure
There was a problem hiding this comment.
That sounds reasonable. I'm not sure I can do much about it from that side, but there is no other way to create that schematic without checking the templates 😁
kara
added
action: merge
Introduces a new update schematic called "template-var-assignment" that is responsible for analyzing template files in order to warn developers if template variables are assigned to values. The schematic also comes with a driver for `tslint` so that the check can be used wtihin Google. PR Close #29608
Introduces a new update schematic called "template-var-assignment" that is responsible for analyzing template files in order to warn developers if template variables are assigned to values. The schematic also comes with a driver for `tslint` so that the check can be used wtihin Google. PR Close angular#29608
Introduces a new update schematic called "template-var-assignment" that is responsible for analyzing template files in order to warn developers if template variables are assigned to values. The schematic also comes with a driver for `tslint` so that the check can be used wtihin Google. PR Close angular#29608
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Introduces a new update schematic called "template-var-assignment"
that is responsible for analyzing template files in order to warn
developers if template variables are assigned to values.
The schematic also comes with a driver for
tslintso that thecheck can be used wtihin Google.