feat(compiler-cli): ngcc - make logging more configurable #29591
Conversation
petebacondarwin
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
petebacondarwin
force-pushed
the
FW-1198
branch
2 times, most recently
from
d520e0d
to
3259fc6
Compare
|
I'm going to open up the API a bit more... |
petebacondarwin
added
state: WIP
and removed
action: merge
This allows CLI usage to filter excessive log messages and integrations like webpack plugins to provide their own logger. // FW-1198
petebacondarwin
force-pushed
the
FW-1198
branch
from
3259fc6
to
92d26d3
Compare
gkalpak
added
action: merge
| export const WARN = `${YELLOW}Warning:${RESET}`; | ||
| export const ERROR = `${RED}Error:${RESET}`; | ||
|
|
||
| export enum LogLevel { |
There was a problem hiding this comment.
I don't know. We don't currently appear to :-) We can always add it later.
| * The function will recurse into directories that start with `@...`, e.g. `@angular/...`. | ||
| * @param sourceDirectory An absolute path to the root directory where searching begins. | ||
| */ | ||
| private walkDirectoryForEntryPoints(sourceDirectory: AbsoluteFsPath): EntryPoint[] { |
There was a problem hiding this comment.
I don't see these functions using the logger at all - is the fact that they're now private class methods instead of top-level functions related to the logging change?
There was a problem hiding this comment.
Yes the getEntryPointsForPackage() method calls getEntryPointInfo(), which needs a logger.
I was really unhappy with having to pass the Logger down to that free standing function but as much as a played around I could not get a better architecture, without a significant refactoring of this whole bit of the codebase.
) This allows CLI usage to filter excessive log messages and integrations like webpack plugins to provide their own logger. // FW-1198 PR Close angular#29591
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This allows CLI usage and integrations like webpack plugins
to filter excessive log messages.
// FW-1198