fix(core): static-query schematic should detect queries in "ngDoCheck" and "ngOnChanges" #29492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
action: review
kara
added
action: cleanup
devversion
force-pushed
the
fix/core-schematics-ng-do-check-ng-on-changes
branch
from
6a13740
to
3ecf65d
Compare
…" and "ngOnChanges" Queries can be also used statically within the "ngDoCheck" and "ngOnChanges" lifecylce hook. In order to properly detect all queries, we need to also respect these lifecycle hooks. Resolves FW-1192
devversion
force-pushed
the
fix/core-schematics-ng-do-check-ng-on-changes
branch
from
3ecf65d
to
6938d5d
Compare
kara
removed
the
action: cleanup
kara
added
action: merge
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…" and "ngOnChanges" (angular#29492) Queries can be also used statically within the "ngDoCheck" and "ngOnChanges" lifecylce hook. In order to properly detect all queries, we need to also respect these lifecycle hooks. Resolves FW-1192 PR Close angular#29492
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries can be also used statically within the "ngDoCheck" and "ngOnChanges" lifecylce hook.
In order to properly detect all queries, we need to also respect these lifecycle hooks.
Resolves FW-1192