Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove @angular/http dependency from @angular/platform-server #29408

Closed
wants to merge 1 commit into from
Closed

feat: remove @angular/http dependency from @angular/platform-server #29408

wants to merge 1 commit into from

Conversation

CaerusKaru
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Migration path includes not using @angular/http or libraries that use it while rendering on the server

Other information

@CaerusKaru CaerusKaru requested review from a team as code owners March 20, 2019 00:42
@CaerusKaru CaerusKaru force-pushed the adam/http-server branch 3 times, most recently from 547afdc to 74d6653 Compare March 20, 2019 01:06
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Mar 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 21, 2019
@vikerman vikerman requested review from alexeagle and removed request for a team March 27, 2019 06:58
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2019
@alexeagle alexeagle mentioned this pull request Mar 27, 2019
Closed
@mhevery mhevery closed this in 9745f55 Mar 27, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@CaerusKaru @wKoza
feat: remove @angular/http dependency from @angular/platform-server (a…
feadac8 
…ngular#29408)

PR Close angular#29408
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
@CaerusKaru CaerusKaru deleted the adam/http-server branch May 12, 2020 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@vikerman vikerman vikerman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CaerusKaru @alexeagle @vikerman @matsko @googlebot