fix(router): support NgFactory promise in loadChildren typings #29392
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
added
target: major
|
You can preview b1a3cdb at https://pr29392-b1a3cdb.ngbuilds.io/. |
The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail.
|
You can preview 2e2a8aa at https://pr29392-2e2a8aa.ngbuilds.io/. |
This was referenced Mar 19, 2019
IgorMinar
added
action: merge
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ar#29392) The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail. PR Close angular#29392
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The router loadChildren property already supports a promise that returnes a NgModuleFactory, but the typings cause the compilation to fail.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail.
What is the new behavior?
Typings contain the correct supported types.
Does this PR introduce a breaking change?
Other information