Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bazel): Upgrade rules_sass #29388

Closed
wants to merge 1 commit into from
Closed

feat(bazel): Upgrade rules_sass #29388

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Mar 18, 2019
@kyliau kyliau requested a review from a team as a code owner March 18, 2019 23:45
@ngbot ngbot bot added this to the needsTriage milestone Mar 18, 2019
@kyliau kyliau requested a review from a team as a code owner March 19, 2019 00:11
@kyliau kyliau force-pushed the sass branch 3 times, most recently from 697637f to 9d24839 Compare March 19, 2019 18:48
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Mar 19, 2019
@kyliau
Copy link
Contributor Author

kyliau commented Mar 19, 2019

caretaker: tests are done and are all green but CircleCI status was not updated.

@kyliau kyliau added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 19, 2019
@alexeagle
Copy link
Contributor

Greg landed a change today, looks like this needs a rebase?
Also framework just released beta.9 which we should pick up, has the ngfactory UMD change

@kyliau kyliau changed the title feat(bazel): Upgrade rules_nodejs and rules_sass feat(bazel): Upgrade rules_sass Mar 20, 2019
@matsko matsko closed this in d6d081e Mar 20, 2019
@kyliau kyliau deleted the sass branch March 22, 2019 22:33
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@kyliau @wKoza
feat(bazel): Upgrade rules_nodejs and rules_sass (angular#29388)
243bb2f 
PR Close angular#29388
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @alexeagle @mgechev @googlebot