fix(bazel): correct regexp test for self-references in metadata #29346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test that catches the mistake, should have had this in the previous change
alexeagle
added
target: major
mgechev
approved these changes
Mar 15, 2019
gkalpak
reviewed
Mar 16, 2019
| @@ -415,7 +415,7 @@ export * from '${srcDirRelative(inputPath, typingsFile.replace(/\.d\.tsx?$/, '') | |||
| if (metadata.exports) { | |||
| // Strip re-exports which are now self-references | |||
| metadata.exports = | |||
| metadata.exports.filter((e: {from: string}) => !relativePathRegex.test(e.from)); | |||
| metadata.exports.filter((e: {from: string}) => !e.from.match(relativePathRegex)); | |||
There was a problem hiding this comment.
Might be worth adding a comment here, because .test() seems like the right thing to do and is easy to miss the implications of the g flag.
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…lar#29346) Add a test that catches the mistake, should have had this in the previous change PR Close angular#29346
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that catches the mistake, should have had this in the previous change