fix(core): parse incorrect ML open tag as text #29328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR alligns markup language lexer with the previous behaviour in version 7.x: https://stackblitz.com/edit/angular-iancj2 While this behaviour is not perfect (we should be giving users an error message here about invalid HTML instead of assuming text node) this is probably best we can do without more substential re-write of lexing / parsing infrastructure. This PR just fixes angular#29231 and restores VE behaviour - a more elaborate fix will be done in a separate PR as it requries non-trivial rewrites.
pkozlowski-opensource
added
action: review
mhevery
approved these changes
Mar 15, 2019
petebacondarwin
approved these changes
Mar 16, 2019
kara
added
action: merge
|
@pkozlowski-opensource I'm reverting + reopening this so that it doesn't land into the release later today. I will re-merge this PR tomorrow morning. |
matsko
added a commit
that referenced
this pull request
Mar 19, 2019
|
@matsko FYI, this commit is fine to go in the release. It just doesn't have to go out in the release. |
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
This PR alligns markup language lexer with the previous behaviour in version 7.x: https://stackblitz.com/edit/angular-iancj2 While this behaviour is not perfect (we should be giving users an error message here about invalid HTML instead of assuming text node) this is probably best we can do without more substential re-write of lexing / parsing infrastructure. This PR just fixes angular#29231 and restores VE behaviour - a more elaborate fix will be done in a separate PR as it requries non-trivial rewrites. PR Close angular#29328
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
This PR alligns markup language lexer with the previous behaviour in version 7.x: https://stackblitz.com/edit/angular-iancj2 While this behaviour is not perfect (we should be giving users an error message here about invalid HTML instead of assuming text node) this is probably best we can do without more substential re-write of lexing / parsing infrastructure. This PR just fixes angular#29231 and restores VE behaviour - a more elaborate fix will be done in a separate PR as it requries non-trivial rewrites. PR Close angular#29328
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns markup language lexer with the previous behaviour in version 7.x:
https://stackblitz.com/edit/angular-iancj2
While this behaviour is not perfect (we should be giving users an error message
here about invalid HTML instead of assuming text node) this is probably best we
can do without more substantial re-write of lexing / parsing infrastructure.
This PR just fixes #29231 and restores VE behaviour - a more elaborate fix will
be done in a separate PR as it requires non-trivial rewrites.