Skip to content

fix(bazel): don't produce self-references in metadata #29317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): don't produce self-references in metadata #29317

wants to merge 1 commit into from
+8 −2

Conversation

alexeagle
Copy link
Contributor

Fixes #29315

@alexeagle alexeagle requested review from alxhub and alan-agius4 March 14, 2019 22:00
@alexeagle alexeagle requested a review from a team as a code owner March 14, 2019 22:00
alxhub
alxhub approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexeagle alexeagle added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Mar 14, 2019
@alexeagle alexeagle removed the request for review from alan-agius4 March 14, 2019 23:11
@matsko matsko closed this in 3facdeb Mar 15, 2019
@alan-agius4
Copy link
Contributor

Do we understand how none of the integration tests caught this issue?

@alexeagle
Copy link
Contributor Author

@alan-agius4 discussed that with @kyliau - we think the app in integration/bazel is too simple to exercise the codepath of resolving these symbols

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@alexeagle @wKoza
fix(bazel): don't produce self-references in metadata (angular#29317)
d0351e1 
Fixes angular#29315

PR Close angular#29317
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev

@alxhub alxhub

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dts bundling produces broken metadata.json
5 participants
@alexeagle @alan-agius4 @mgechev @alxhub @googlebot