Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): allow Z variations of CSS transforms in sanitizer #29264

Closed
wants to merge 1 commit into from
Closed

fix(core): allow Z variations of CSS transforms in sanitizer #29264

wants to merge 1 commit into from

Conversation

foolmoron
Copy link
Contributor

@foolmoron foolmoron commented Mar 12, 2019 •
edited

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Sanitizer regex does not allow the Z variations of CSS transform values (translateZ, rotateZ, etc) which are supposed to be valid

Issue Number: N/A

What is the new behavior?

Z variations of CSS transform values are allowed through the sanitizer, like the X and Y variations

Does this PR introduce a breaking change?

  • Yes
  • No

@foolmoron foolmoron requested a review from a team as a code owner March 12, 2019 19:16
@kara kara added the area: core Issues related to the framework runtime label Mar 12, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 12, 2019
@foolmoron
Copy link
Contributor Author

Anything I can do to get this fix in?

@mhevery mhevery self-assigned this Jul 17, 2019
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 17, 2019
@ngbot
Copy link

ngbot bot commented Jul 17, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    pending missing required labels: PR target: *
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery mhevery added the target: major This PR is targeted for the next major release label Jul 18, 2019
@mhevery
Copy link
Contributor

mhevery commented Jul 18, 2019

http://test/OCL:258795950:BASE:258795963:1563470595209:cf47b3

@mhevery mhevery closed this in 78e7fdd Jul 18, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@foolmoron @sabeersulaiman
fix(core): allow Z variations of CSS transforms in sanitizer (angular…
5649780 
…#29264)

PR Close angular#29264
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@foolmoron @mhevery @kara @googlebot