Skip to content

fix(compiler): inherit param types when class has a constructor which… #29232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(compiler): inherit param types when class has a constructor which… #29232

wants to merge 2 commits into from

Conversation

bolu
Copy link
Contributor

@bolu bolu commented Mar 11, 2019

… takes no declared parameters and delegates up

In ReflectionCapabilities, when checking for own parameters of a type, inherit the types properly for classes that do have a constructor, but the constructor takes no declared parameters and just delegates to super(...arguments). This removes the need to declare trivial constructors in such classes to make them work properly in JIT mode. Without this, DI fails and injectables are undefined.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@bolu bolu requested a review from a team as a code owner March 11, 2019 20:53
@kara kara added the area: core Issues related to the framework runtime label Mar 12, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 12, 2019
kara
kara approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 12, 2019
@kara kara requested a review from alxhub March 12, 2019 18:23
@kara kara added the target: major This PR is targeted for the next major release label Mar 12, 2019
@kara kara removed the request for review from alxhub March 12, 2019 18:25
@kara kara added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 12, 2019
alxhub
alxhub reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bolu,

How hard do you think it would be to add a test for this fix?

alxhub
alxhub requested changes Mar 12, 2019
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for the test)

alxhub
alxhub requested changes Mar 12, 2019
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please merge your two commits into one single commit. git rebase -i is useful for this.

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 12, 2019
@kara
Copy link
Contributor

kara commented Mar 12, 2019

presubmit

@kara kara added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2019
@matsko
Copy link
Contributor

matsko commented Mar 14, 2019 •
edited
Loading

http://test/OCL:238513286:BASE:238513362:1552597194178:27e13635

bolu and others added 2 commits March 21, 2019 16:06
@bolu @mhevery
fix(compiler): inherit param types when class has a constructor which…
cf242ab 
… takes no declared parameters and delegates up

In ReflectionCapabilities, when checking for own parameters of a type, inherit the types properly for classes that do have a constructor, but the constructor takes no declared parameters and just delegates to super(...arguments). This removes the need to declare trivial constructors in such classes to make them work properly in JIT mode. Without this, DI fails and injectables are undefined.
@mhevery
fixup! fix(compiler): inherit param types when class has a constructo…
457923f 
…r which takes no declared parameters and delegates up
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mhevery mhevery added cla: yes and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: no labels Mar 21, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mhevery mhevery closed this in 0007564 Mar 22, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@bolu @wKoza
fix(compiler): inherit param types when class has a constructor which…
7877807 
… takes no declared parameters and delegates up (angular#29232)

In ReflectionCapabilities, when checking for own parameters of a type, inherit the types properly for classes that do have a constructor, but the constructor takes no declared parameters and just delegates to super(...arguments). This removes the need to declare trivial constructors in such classes to make them work properly in JIT mode. Without this, DI fails and injectables are undefined.

PR Close angular#29232
This was referenced May 9, 2019
Closed
Closed
@petebacondarwin
Copy link
Contributor

Here are the tests that never appeared in this PR: #30368

@CreepyGnome CreepyGnome mentioned this pull request May 13, 2019
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara

@alxhub alxhub

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bolu @kara @matsko @googlebot @petebacondarwin @alxhub @mhevery