-
Notifications
You must be signed in to change notification settings - Fork 26.2k
Update to nodejs rules 0.27 #29210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to nodejs rules 0.27 #29210
Conversation
d841b63
to
06b3bf2
Compare
06b3bf2
to
9da15a6
Compare
70ccdfc
to
37b9d30
Compare
e498ca2
to
37b9d30
Compare
c56b6bd
to
ab2bda6
Compare
Note:
if The
There are also |
For reference, rollup version was updated here bazel-contrib/rules_nodejs#584 which brough in the |
# which tree shakes @__PURE__ annotations by default. We turn this feature off | ||
# for ng_package as Angular bundles contain these annotations and there are | ||
# test failures if they are removed. See comments in | ||
# https://github.com/angular/angular/pull/29210 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah seems like a bug for these annotations to be tree-shaken in the testing bundles? since many tests need them in JIT mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a rollup bug. I think libraries need to be run rollup with this option turned off, and applications need to run with it turned on.
2fa4eb5
to
a54d507
Compare
67dcd15
to
ceef0ea
Compare
e2a9d59
to
3dc868c
Compare
"rollup": "^0.41.6", | ||
"rollup-plugin-commonjs": "^8.0.2", | ||
"rollup-plugin-node-resolve": "2.0.0", | ||
"rollup": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollup needed an upgrade to fix test failures in the upgrade-phonecat-2-hybrid
test. It seems like rollup 0.41.6 couldn't handle the angular bundles produced by rollup 1.3.1 (which is what ng_packager now uses since it shares the version with rollup_bundle).
Caretaker: has global approval |
This reverts commit b2aadff.
This reverts commit fc8048d.
This reverts commit 08231f0.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.