fix(bazel): add missing binary path for api-extractor #29202
Closed
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: major
`api-extractor` binary is required for external consumers of `ng_module` that want to use the `bundle_dts` flag. This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.
alexeagle
approved these changes
Mar 11, 2019
|
g3 error, FYI I'll have to submit an internal change first. |
|
mailed cl/237816725 to @mgechev to unblock this |
kara
added
the
action: review
alan-agius4
removed
the
action: review
|
Caretaker: @alexeagle should be enough for this. |
alan-agius4
added
merge: caretaker note
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
`api-extractor` binary is required for external consumers of `ng_module` that want to use the `bundle_dts` flag. This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external. PR Close angular#29202
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api-extractorbinary is required for external consumers ofng_modulethat want to use thebundle_dtsflag.This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.