Skip to content

fix(bazel): ng build should produce prod bundle #29136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): ng build should produce prod bundle #29136

wants to merge 1 commit into from
+2 −7

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 6, 2019

ng build should produce a bundle that could be readily deployed to
a web server, similar to the behavior of current ng build with
webpack.

Note that in Bazel, there is no ng build for dev bundles. Instead,
users are expected to run ts_devserver.

Closes #28877

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@kyliau kyliau requested a review from mgechev March 6, 2019 19:05
@kyliau kyliau requested a review from a team as a code owner March 6, 2019 19:05
@kyliau
fix(bazel): ng build should produce prod bundle

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7e143ba 
`ng build` should produce a bundle that could be readily deployed to
a web server, similar to the behavior of current `ng build` with
webpack.

Note that in Bazel, there is no `ng build` for dev bundles. Instead,
users are expected to run `ts_devserver`.

Closes angular#28877
@kyliau kyliau added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Mar 6, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 6, 2019
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Mar 7, 2019
@kara kara closed this in 14ce8a9 Mar 7, 2019
@kyliau kyliau deleted the ngbuild branch March 22, 2019 22:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgechev mgechev

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Produce all application assets on ng build with Bazel schematics
3 participants
@kyliau @mgechev @googlebot