feat(platform-server): wait on returned BEFORE_APP_SERIALIZED promises #29120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdbradley
changed the title
vikerman
approved these changes
Mar 5, 2019
This update gives external tooling the ability for async providers to finish resolving before the document is serialized. This is not a breaking change since render already returns a promise. All returned promises from `BEFORE_APP_SERIALIZED` providers will wait to be resolved or rejected. Any rejected promises will only console.warn().
adamdbradley
force-pushed
the
async-before-serialize
branch
from
7e93a82
to
317a52f
Compare
vikerman
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Render does not wait on any returned promises from
BEFORE_APP_SERIALIZED.What is the new behavior?
This update gives external tooling the ability for async providers to
finish resolving before the document is serialized. This is not a
breaking change since render already returns a promise. All returned
promises from
BEFORE_APP_SERIALIZEDproviders will wait to beresolved or rejected. Any rejected promises will only console.warn().
Does this PR introduce a breaking change?