Skip to content

feat(bazel): Hide Bazel files in Bazel builder #29110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(bazel): Hide Bazel files in Bazel builder #29110

wants to merge 1 commit into from
+553 −96

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 5, 2019

This commit modifies the Bazel builder to copy the Bazel WORKSPACE and
BUILD.bazel files to the project root directory before invoking Bazel.

This hides the Bazel files from users.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added state: WIP target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Mar 5, 2019
@kyliau kyliau requested a review from a team as a code owner March 5, 2019 00:38
@ngbot ngbot bot modified the milestone: needsTriage Mar 5, 2019
@kyliau kyliau force-pushed the builder branch 3 times, most recently from 1f351e1 to 9bca2b6 Compare March 5, 2019 06:05
@kyliau kyliau requested a review from a team as a code owner March 5, 2019 06:05
@kyliau kyliau removed the state: WIP label Mar 5, 2019
@kyliau kyliau requested review from alexeagle and hansl March 5, 2019 06:39
@kyliau
Copy link
Contributor Author

kyliau commented Mar 6, 2019

Added safeguard to not overwrite existing Bazel files, removed hard-coded Bazel file paths, and converted implementation to use Promise.
PTAL.

@kyliau
feat(bazel): Hide Bazel files in Bazel builder
4ee9b8f 
This commit modifies the Bazel builder to copy the Bazel WORKSPACE and
BUILD.bazel files to the project root directory before invoking Bazel.

This hides the Bazel files from users.
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Mar 7, 2019
@kara kara closed this in 7060d90 Mar 7, 2019
@kyliau kyliau deleted the builder branch March 7, 2019 01:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl

@alexeagle alexeagle

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @alexeagle @hansl @googlebot