fix(core): call ngOnDestroy for tree-shakeable providers #28943
Closed
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, any provider that was independently resolved using its InjectableDef would not be considered when destroying the module it was requested from. This commit provides a fix for this issue by storing the resolved provider in the module's list of provider definitions. Fixes angular#28927
This test verifies that Ivy's module injector does not suffer from angular#28927 to prevent regressing on this behavior going forward.
JoostK
commented
Feb 23, 2019
| @@ -109,7 +109,7 @@ export function resolveNgModuleDep( | |||
| } else if ( | |||
| (injectableDef = getInjectableDef(depDef.token)) && targetsModule(data, injectableDef)) { | |||
| const index = data._providers.length; | |||
| data._def.providersByKey[depDef.tokenKey] = { | |||
| data._def.providers[index] = data._def.providersByKey[depDef.tokenKey] = { | |||
There was a problem hiding this comment.
I believe this can not make data._def.providers sparse, as the indices should be aligned. I'd like a second opinion on this though :)
|
/cc @alxhub |
JoostK
changed the title
mhevery
approved these changes
Apr 4, 2019
mhevery
added
action: merge
IgorMinar
pushed a commit
that referenced
this pull request
Apr 5, 2019
DeveloperFromUkraine
pushed a commit
to DeveloperFromUkraine/angular
that referenced
this pull request
Apr 11, 2019
Prior to this change, any provider that was independently resolved using its InjectableDef would not be considered when destroying the module it was requested from. This commit provides a fix for this issue by storing the resolved provider in the module's list of provider definitions. Fixes angular#28927 PR Close angular#28943
DeveloperFromUkraine
pushed a commit
to DeveloperFromUkraine/angular
that referenced
this pull request
Apr 11, 2019
…ngular#28943) This test verifies that Ivy's module injector does not suffer from angular#28927 to prevent regressing on this behavior going forward. PR Close angular#28943
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Prior to this change, any provider that was independently resolved using its InjectableDef would not be considered when destroying the module it was requested from. This commit provides a fix for this issue by storing the resolved provider in the module's list of provider definitions. Fixes angular#28927 PR Close angular#28943
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ngular#28943) This test verifies that Ivy's module injector does not suffer from angular#28927 to prevent regressing on this behavior going forward. PR Close angular#28943
|
@mhevery @JoostK Any chance of having this PR applied to the 7.2.x release? Given IE11 has trouble reclaiming memory on active observables (which are not cancelled with the takeUntil in ngOnDestroy) this is a really critical issue. Also, switching back all services spread across several libraries (including 3rd party one such as Material) to the forRoot approach is quite a significant amount of work. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #28927
Prior to this change, any provider that was independently resolved using
its InjectableDef would not be considered when destroying the module it
was requested from.
What is the new behavior?
This commit provides a fix for this issue by storing
the resolved provider in the module's list of provider definitions.
Additionally, a test for Ivy's module injector was added to prevent
regressing on this behavior going forward.
Does this PR introduce a breaking change?