Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngOnDestroy on providedIn: 'root' service not called #28927

Closed
sod opened this issue Feb 22, 2019 · 2 comments
Closed

ngOnDestroy on providedIn: 'root' service not called #28927

sod opened this issue Feb 22, 2019 · 2 comments
Labels
area: core Issues related to the framework runtime
Milestone
needsTriage

Comments

@sod
Copy link
Contributor

sod commented Feb 22, 2019

angular 7.2.5 - reproduction: https://stackblitz.com/edit/angular-begg91

Issue
When you call destroy() on an application, ngOnDestroy on services that are @Injectable({providedIn: 'root'}), is never called.

@Injectable() // injected in an NgModule
export class ServiceInModule {
    ngOnDestroy() {} // <- working: is called when app is destroyed
}

@Injectable({providedIn: 'root'})
export class ServiceProvidedInRoot {
    ngOnDestroy() {} // <- not working: is never called
}

You see here, the constructor of ServiceProvidedInRoot is called in both bootstraps ... so it's not reused and should be parse of the livecycle. But ngOnDestroy is not called if module is destroyed:

image

This is currently an issue for as as we try to use angular/universal, but we can't tear down objects in services when provided in root.
@benlesh benlesh added the area: core Issues related to the framework runtime label Feb 22, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 22, 2019
JoostK added a commit to JoostK/angular that referenced this issue Feb 23, 2019
@JoostK
fix(core): call ngOnDestroy for tree-shakeable providers
f33eb94 
Prior to this change, any provider that was independently resolved using
its InjectableDef would not be considered when destroying the module it
was requested from. This commit provides a fix for this issue by storing
the resolved provider in the module's list of provider definitions.

Fixes angular#28927
JoostK added a commit to JoostK/angular that referenced this issue Feb 23, 2019
@JoostK
test(ivy): verify ngOnDestroy is called for tree-shakeable providers
7a33968 
This test verifies that Ivy's module injector does not suffer from
angular#28927 to prevent regressing on this behavior going forward.
@JoostK JoostK mentioned this issue Feb 23, 2019
Closed
14 tasks
@JoostK
Copy link
Member

JoostK commented Feb 23, 2019

Thanks for the StackBlitz, that helped in tracking down this issue. I opened PR #28943 to fix it.

IgorMinar pushed a commit that referenced this issue Apr 5, 2019
@JoostK @IgorMinar
test(ivy): verify ngOnDestroy is called for tree-shakeable providers (#…
5c13fee 
…28943)

This test verifies that Ivy's module injector does not suffer from
#28927 to prevent regressing on this behavior going forward.

PR Close #28943
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this issue Apr 11, 2019
@JoostK @DeveloperFromUkraine
fix(core): call ngOnDestroy for tree-shakeable providers (angular#28943)
490f299 
Prior to this change, any provider that was independently resolved using
its InjectableDef would not be considered when destroying the module it
was requested from. This commit provides a fix for this issue by storing
the resolved provider in the module's list of provider definitions.

Fixes angular#28927

PR Close angular#28943
DeveloperFromUkraine pushed a commit to DeveloperFromUkraine/angular that referenced this issue Apr 11, 2019
@JoostK @DeveloperFromUkraine
test(ivy): verify ngOnDestroy is called for tree-shakeable providers (a…
9e632f6 
…ngular#28943)

This test verifies that Ivy's module injector does not suffer from
angular#28927 to prevent regressing on this behavior going forward.

PR Close angular#28943
wKoza pushed a commit to wKoza/angular that referenced this issue Apr 17, 2019
@JoostK @wKoza
fix(core): call ngOnDestroy for tree-shakeable providers (angular#28943)
a3368c5 
Prior to this change, any provider that was independently resolved using
its InjectableDef would not be considered when destroying the module it
was requested from. This commit provides a fix for this issue by storing
the resolved provider in the module's list of provider definitions.

Fixes angular#28927

PR Close angular#28943
wKoza pushed a commit to wKoza/angular that referenced this issue Apr 17, 2019
@JoostK @wKoza
test(ivy): verify ngOnDestroy is called for tree-shakeable providers (a…
bb1469c 
…ngular#28943)

This test verifies that Ivy's module injector does not suffer from
angular#28927 to prevent regressing on this behavior going forward.

PR Close angular#28943
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: core Issues related to the framework runtime
Projects
None yet
Milestone
needsTriage
Development

No branches or pull requests
3 participants
@JoostK @sod @benlesh