Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform-browser): add doubletap HammerJS support #26362

Closed
wants to merge 1 commit into from
Closed

feat(platform-browser): add doubletap HammerJS support #26362

wants to merge 1 commit into from

Conversation

tiliev
Copy link

@tiliev tiliev commented Oct 10, 2018 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Angular does not support HammerJS doubletap.
Issue Number: #23954

What is the new behavior?

Angular supports HammerJS doubletap.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@tiliev tiliev changed the title feat(events): Added doubletap HammerJS support. (#23954) feat(platform-browser): Added doubletap HammerJS support (#23954) Oct 10, 2018
@tiliev tiliev changed the title feat(platform-browser): Added doubletap HammerJS support (#23954) feat(platform-browser): add doubletap HammerJS support (#23954) Oct 10, 2018
@tiliev tiliev changed the title feat(platform-browser): add doubletap HammerJS support (#23954) feat(platform-browser): add doubletap HammerJS support Oct 10, 2018
@kdinev kdinev mentioned this pull request Nov 28, 2018
Closed
@matsko matsko added the area: core Issues related to the framework runtime label Dec 20, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 20, 2018
@fksik
Copy link

fksik commented May 7, 2020 •
edited

can any one verify and merge this pull request

@pullapprove pullapprove bot requested a review from mhevery May 7, 2020 21:30
@mhevery mhevery self-assigned this Nov 20, 2020
@google-cla
Copy link

google-cla bot commented Nov 20, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 20, 2020
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 20, 2020
@ngbot
Copy link

ngbot bot commented Nov 20, 2020

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    failure status "cla/google" is failing
    pending missing required labels: cla: yes
    pending forbidden labels detected: cla: no
    pending status "google3" is pending
    pending status "pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery mhevery added cla: yes and removed cla: no labels Nov 20, 2020
@google-cla
Copy link

google-cla bot commented Nov 20, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 20, 2020
@mhevery mhevery added cla: yes and removed cla: no labels Nov 20, 2020
@AndrewKushnir AndrewKushnir added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 20, 2020
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Nov 20, 2020
@AndrewKushnir
Copy link
Contributor

@mhevery FYI I've added the "cleanup" flag since CI is "red", feel free to remove it once CI is "green". It looks like we may also need to run a presubmit (so I've added the "presubmit" label). Thank you.

@mhevery
feat(platform-browser): add doubletap HammerJS support
31cc5b7 
Enables `doubletap` support in HammerJS.

PR Close  angular#23954
@google-cla
Copy link

google-cla bot commented Nov 20, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 20, 2020
@mhevery mhevery added cla: yes action: merge The PR is ready for merge by the caretaker and removed cla: no action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: presubmit The PR is in need of a google3 presubmit labels Nov 20, 2020
@mhevery
Copy link
Contributor

mhevery commented Nov 23, 2020

presubmit

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tiliev @fksik @AndrewKushnir @mhevery @matsko @googlebot