Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please make Angular support HammerJs's doubletap. #23954

Closed
shen-bing opened this issue May 17, 2018 · 2 comments
Closed

Please make Angular support HammerJs's doubletap. #23954

shen-bing opened this issue May 17, 2018 · 2 comments
Labels
area: core Issues related to the framework runtime core: event listeners feature Issue that requests a new feature
Milestone
Backlog

Comments

@shen-bing
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Angular doesn't support HammerJs's doubletap.

Expected behavior

Angular should support HammerJs's doubletap. Just add an item "'doubletap': true," to the object EVENT_NAMES in the "platform-browser/src/dom/events/hammer_gestures.ts" file should be ok.

Environment


Angular version: 6.0.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [x] Safari (iOS) version 10
- [ ] IE version XX
- [ ] Edge version XX


Others:
@vicb vicb added feature Issue that requests a new feature area: common Issues related to APIs in the @angular/common package labels May 22, 2018
@ngbot ngbot bot added this to the Backlog milestone May 22, 2018
@vicb
Copy link
Contributor

vicb commented May 22, 2018

@shen-bing would you like to try and make a PR for this ?

tiliev pushed a commit to tiliev/angular that referenced this issue Oct 10, 2018
feat(events): Added doubletap HammerJS support. (angular#23954)
d1c0f93
@tiliev tiliev mentioned this issue Oct 10, 2018
Closed
3 tasks
tiliev pushed a commit to tiliev/angular that referenced this issue Oct 10, 2018
feat(platform-browser): Added doubletap HammerJS support (angular#23954)
990f67d
@tiliev tiliev mentioned this issue Oct 10, 2018
Closed
tiliev pushed a commit to tiliev/angular that referenced this issue Oct 10, 2018
feat(platform-browser): add doubletap HammerJS support (angular#23954)
af8e594
tiliev pushed a commit to tiliev/angular that referenced this issue Oct 10, 2018
feat(platform-browser): add doubletap HammerJS support
37d73b0 
PR Close  angular#23954
@pkozlowski-opensource pkozlowski-opensource added area: core Issues related to the framework runtime and removed area: common Issues related to APIs in the @angular/common package labels Dec 19, 2018
mhevery pushed a commit to tiliev/angular that referenced this issue Nov 20, 2020
@mhevery
feat(platform-browser): add doubletap HammerJS support
fc97b3e 
Enables `doubletap` support in HammerJS.

PR Close  angular#23954
mhevery pushed a commit to tiliev/angular that referenced this issue Nov 20, 2020
@mhevery
feat(platform-browser): add doubletap HammerJS support
31cc5b7 
Enables `doubletap` support in HammerJS.

PR Close  angular#23954
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: core Issues related to the framework runtime core: event listeners feature Issue that requests a new feature
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@vicb @pkozlowski-opensource @shen-bing