I'm very thankful for this fix. I hope it's gonna get merged soon!

Oops, just found out #15721 can only be fixed by combining this one and #15723 together...

EDIT: divided into two commits.

Hi @trotyl! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

Please, @trotyl can you finish this? It would be a huge help

@headsetsniper It's just waiting for review, conflicts are left deliberately to understand when would the review happening.

Please, can someone review this PR? We now have to work around this issue. The PR is so small and would help a lot of people.

@trotyl Could i review it? i cant merge it but is there something i could do? Its a huge pain in our current project and i cant believe its open since February. Maybe it gets merged quicker if someone resolves the conflicts?

@trotyl Or even better, if we resolve the conflicts, i can reference this branch in our project until it gets merged, right?

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

@SebastianAtWork Rebased, feel free to fetch and use, but better to checkout another branch if you want to keep it up-to-date.

CLAs look good, thanks!

@trotyl Thanks, unfortunately its currently not possible to build angular on a windows machine so i had to fix the core.js directly and made sure (per postpublish npm script) that the change is not overwritten on install. dirty fix but at least its working until someone accepts this pr

I could really use this PR. Bump.

Have had a second thought, the change made in #15723 is correct and mine was wrong.

#18129 is likely a different issue (or not an issue) which I cannot reproduce.

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/circleci: integration_test" is failing
     status "ci/circleci: test_aio" is failing
     status "ci/circleci: test_docs_examples_ivy" is failing
     missing required labels: PR target: *
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Have had a second thought, the change made in #15723 is correct and mine was wrong.

So should this be merged or closed?

@mhevery The other one was closed by @IgorMinar in favor of this one.

@trotyl We just need to get this one passing CI. :)

@mhevery Sorry for the confusion, I meant that my previous thoughts about WrappedValue is wrong, this should just be handled solely by change AsyncPipe.

@benlesh I'll fix the CI.

Hi @benlesh, I have rebased the change, the failure in DoCheck example seems to be a flake, which doesn't use async pipe and passed in my local environment.

presubmit

@trotyl Can you put together a separate PR for the 7.2.x branch? I was unable to merge this into both there and master due to conflicts, so I'll target master with this one.

@benlesh Created #30023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}