@petersalomonsen what is the status of your pull request? is it still relevant? please fix conflicts if they exist

@splincode It is still relevant. Without it you will have overlapping styles when having multiple angular apps on the same page, which is caused by the app id no being included as it is supposed to be according to the documentation here: https://angular.io/guide/component-styles#inspecting-generated-css

Additionally, current behavior is misleading as APP_ID documentation states that APP_ID should be used as a part of generated attributes for ViewEncapsulation.Emulated (https://angular.io/api/core/APP_ID).

This PR would help me a lot! :-)

@petersalomonsen Are you going to fix PR checks?

@glipecki Can have a look at it.

packages/core/test/render3/imported_renderer2.ts was added after my initial PR. The DomRenderer2Factory was instanced without the app id parameter (that I added in my PR), so I added a dummy app id to get around it. Tests passed locally so hopefully passes the CI too? (I'm not 100% up to speed on all that's going on in the CI tests).

@petersalomonsen This pull request is big!

@splincode Did I merge / rebase the wrong way?

I did this:

git rebase master -i
git push -f

(as written here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md - if changes are suggested (10))

I've only made two commits. These are the only changes: master...petersalomonsen:16676-viewencapsulation-appid

@splincode Should never have used the sync button in visual studio code that created a merge commit. Merge commit is removed now.

@petersalomonsen Can you edit the code according to the formatting rules (default tslint.json)?

@petersalomonsen Use interactive git rebase to combine your little commits into one

@splincode Now combined into one commit. And I've also run gulp format.

All CI tests are passing now. What more can I do for this PR to be accepted?

@petersalomonsen this PR looks great! I also need this fix to allow our micro-apps to have non-conflicting styles when using https://github.com/CanopyTax/single-spa.

Do you know what's preventing this PR from being approved/merged? (Sorry that I'm not familiar with the contribution process.)

@aaaa0441 I think the remaining depends on the Angular repository managers now, but if there's something more I can do to complete the merge I'd be happy to help - so let me know.

@petersalomonsen Thanks for responding. I got your changes and applied the diff to my local node_modules/@angular/platform-browser dependency using patch-package. Works well.

I definitely prefer Angular to have this fixed instead of monkey patching it the way I am doing. However, I have no other way for our project to move on now. =(

Really hope this gets merged soon. Who can we @ to get this expedited?

@aaaa0441 I think @chuckjaz is member of the Angular team and maybe can give some info on what needs to be done to get the merge through.

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/circleci: test_ivy_aot" is failing
     status "code-review/pullapprove" is failing
     missing required labels: PR target: *
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

http://test/OCL:242559681:BASE:242559720:1554765423028:7c055229

@petersalomonsen looks like this is failing some unit tests, including a regex check for the _nghost attribute in

@mleibman I believe the regex checks are fixed now. The circle_ci integration test passed on the previous push, and there were no other changes than a few spaces to please the linter (sorry for not sorting this out locally before pushing).

@petersalomonsen Thanks! I'm not an Angular team member, so I can't review/merge it myself. I'm just facilitating since I depend on this fix :)

CARETAKER: The build failure is bazel build time, which is unrelated to this PR, please merge manually.

is this PR merged to master ?

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}