-
Notifications
You must be signed in to change notification settings - Fork 26.2k
AsyncPipe breaks change detection with NaN values #15721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@DzmitryShylovich ah that makes sense, |
I have a similar issue as this. Seems like unwraping a WrappedValue will cause ExpressionChangedAfterItHasBeenCheckedError. I have a very simple plunker at http://plnkr.co/edit/yZtZjYrypmIQHQyFdukX |
Any news on when this will be fixed/scheduled? |
Yep, any news on that? Since angular 4.2 change detection warnings are more precise and this issue arises much more often I think :) |
@tbosch is this planned to be fixed? :) |
The problem with wrapped values is well explained in #18129, though I'm not 100% sure this issue is only about that... |
…e unwrapped one closes angular#15721, closes angular#18129
…e unwrapped one closes angular#15721, closes angular#18129
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ...
Current behavior
It seems that the
AsyncPipe
emits aWrappedValue
(which appears below as'[object Object]'
) then theNaN
, which causes an expression change:Expected behavior
NaN
should be handled by| async
without breaking change detection.Minimal reproduction of the problem with instructions
Plunkr: https://plnkr.co/edit/Dc6jwz?p=preview
What is the motivation / use case for changing the behavior?
We have various pipes that operate on numbers (to generate friendly and consistent representations) that are loaded asynchronously, so we have quite a few lines that look like:
Please tell us about your environment:
Angular version: 4.0.1
Browser: Chrome 57.0.2987.110, IE 11.0.9600.18537
Language: TypeScript 2.1.6 (local), 2.2.1 (Plunkr)
The text was updated successfully, but these errors were encountered: