fix(core): static-query migration errors not printed properly (#30458)

devversion · alxhub · commit fde3f467e2dc · 2019-05-14T14:04:44.000-07:00
Apparently the devkit logger is not able to properly print out error objects, so we need to convert them to a string before in order to make the error visible to the user. This is not testable without an e2e test that validates the CLI terminal output. PR Close #30458
diff --git a/packages/core/schematics/migrations/static-queries/index.ts b/packages/core/schematics/migrations/static-queries/index.ts
@@ -192,7 +192,7 @@ async function runStaticQueryMigration(
           `the update cannot use the template migration strategy. Please ensure ` +
           `there are no AOT compilation errors.`);
     }
-    logger.error(e);
+    logger.error(e.toString());
     logger.info(
         'Migration can be rerun with: "ng update @angular/core --from 7 --to 8 --migrate-only"');
     return [];

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ async function runStaticQueryMigration(`
`192`	`192`	`the update cannot use the template migration strategy. Please ensure ` +
`193`	`193`	`there are no AOT compilation errors.`);
`194`	`194`	`}`
`195`		`- logger.error(e);`
	`195`	`+ logger.error(e.toString());`
`196`	`196`	`logger.info(`
`197`	`197`	`'Migration can be rerun with: "ng update @angular/core --from 7 --to 8 --migrate-only"');`
`198`	`198`	`return [];`