Skip to content

Commit

Permalink
fix(bazel): do not typecheck core schematic files (#29876)
Browse files Browse the repository at this point in the history
Currently for Angular Bazel projects, NGC needs to be run in the
"postinstall" NPM script in order to generate required summary files.

We need to update the postinstall `tsconfig` to not check/re-build the
`@angular/core` schematic code which has transitive dependencies
which are only available inside of a CLI project. As this is not guaranteed
to be the case with Angular Bazel projects, we need to make sure that
we don't check/re-build these files.

PR Close #29876
  • Loading branch information
devversion authored and benlesh committed Apr 19, 2019
1 parent 22294df commit 2ba799d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions integration/bazel/angular-metadata.tsconfig.json
Expand Up @@ -20,6 +20,7 @@
],
"exclude": [
"node_modules/@angular/bazel/**",
"node_modules/@angular/core/schematics/**",
"node_modules/@angular/compiler-cli/**",
"node_modules/@angular/**/testing/**",
"node_modules/@angular/router/upgrade*"
Expand Down
Expand Up @@ -17,6 +17,7 @@
],
"exclude": [
"node_modules/@angular/bazel/**",
"node_modules/@angular/core/schematics/**",
"node_modules/@angular/compiler-cli/**",
"node_modules/@angular/**/testing/**",
"node_modules/@angular/router/upgrade*"
Expand Down

0 comments on commit 2ba799d

Please sign in to comment.