fix(router): support NgFactory promise in loadChildren typings (#29392)

The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail. PR Close #29392
angular · Mar 25, 2019 · 26a8c59 · 26a8c59
1 parent 4122528
commit 26a8c59
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/router/src/config.ts b/packages/router/src/config.ts
@@ -97,8 +97,8 @@ export type ResolveData = {
  * @see `Route#loadChildren`.
  * @publicApi
  */
-export type LoadChildrenCallback = () =>
-    Type<any>| NgModuleFactory<any>| Promise<Type<any>>| Observable<Type<any>>;
+export type LoadChildrenCallback = () => Type<any>| NgModuleFactory<any>|
+    Promise<NgModuleFactory<any>>| Promise<Type<any>>| Observable<Type<any>>;
 
 /**
  *

diff --git a/tools/public_api_guard/router/router.d.ts b/tools/public_api_guard/router/router.d.ts
@@ -147,7 +147,7 @@ export declare class GuardsCheckStart extends RouterEvent {
 
 export declare type LoadChildren = string | LoadChildrenCallback;
 
-export declare type LoadChildrenCallback = () => Type<any> | NgModuleFactory<any> | Promise<Type<any>> | Observable<Type<any>>;
+export declare type LoadChildrenCallback = () => Type<any> | NgModuleFactory<any> | Promise<NgModuleFactory<any>> | Promise<Type<any>> | Observable<Type<any>>;
 
 export declare type Navigation = {
     id: number;