Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: acquire -> batch #263

Merged
merged 2 commits into from Oct 6, 2020
Merged

Conversation

AlexStocks
Copy link
Contributor

Describe what this PR does / why we need it

change the acquire count which I do not understand to batch count

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #263 into master will increase coverage by 0.03%.
The diff coverage is 62.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   42.82%   42.85%   +0.03%     
==========================================
  Files          79       79              
  Lines        4014     4011       -3     
==========================================
  Hits         1719     1719              
+ Misses       2030     2027       -3     
  Partials      265      265              
Impacted Files Coverage Δ
core/flow/tc_default.go 68.75% <0.00%> (ø)
core/hotspot/slot.go 34.14% <0.00%> (ø)
core/isolation/slot.go 0.00% <0.00%> (ø)
api/api.go 34.32% <33.33%> (-1.06%) ⬇️
core/flow/tc_throttling.go 62.96% <50.00%> (ø)
core/hotspot/traffic_shaping.go 60.13% <87.50%> (ø)
core/base/context.go 51.51% <100.00%> (ø)
core/base/slot_chain.go 97.01% <100.00%> (ø)
core/flow/slot.go 42.85% <100.00%> (ø)
core/flow/standalone_stat_slot.go 66.66% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124be27...32ff5a0. Read the comment docs.

@louyuting louyuting requested review from louyuting and sczyh30 and removed request for louyuting October 4, 2020 01:27
@louyuting louyuting added the kind/enhancement Category issues or PRs related to enhancement label Oct 4, 2020
@louyuting louyuting self-requested a review October 4, 2020 01:28
core/hotspot/traffic_shaping.go Outdated Show resolved Hide resolved
@louyuting louyuting merged commit 8482e02 into alibaba:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants