Revert "Add setNeedsLayout to yoga tree changes. (#1361)"

garrettmoon · garrettmoon · commit ae2b3af9671a · 2019-03-14T10:32:47.000-07:00
This reverts commit babd81b.
diff --git a/Source/ASDisplayNode+Layout.mm b/Source/ASDisplayNode+Layout.mm
@@ -23,19 +23,6 @@
 
 using AS::MutexLocker;
 
-@interface ASDisplayNode (ASLayoutElementStyleDelegate) <ASLayoutElementStyleDelegate>
-@end
-
-@implementation ASDisplayNode (ASLayoutElementStyleDelegate)
-
-#pragma mark <ASLayoutElementStyleDelegate>
-
-- (void)style:(ASLayoutElementStyle *)style propertyDidChange:(NSString *)propertyName {
-  [self setNeedsLayout];
-}
-
-@end
-
 #pragma mark - ASDisplayNode (ASLayoutElement)
 
 @implementation ASDisplayNode (ASLayoutElement)
@@ -59,9 +46,8 @@ - (ASLayoutElementStyle *)style
 
 - (ASLayoutElementStyle *)_locked_style
 {
-  ASAssertLocked(__instanceLock__);
   if (_style == nil) {
-    _style = [[ASLayoutElementStyle alloc] initWithDelegate:self];
+    _style = [[ASLayoutElementStyle alloc] init];
   }
   return _style;
 }
diff --git a/Source/ASDisplayNode+Yoga.mm b/Source/ASDisplayNode+Yoga.mm
@@ -93,7 +93,6 @@ - (void)_locked_removeYogaChild:(ASDisplayNode *)child
 
   // YGNodeRef removal is done in setParent:
   child.yogaParent = nil;
-  [self setNeedsLayout];
 }
 
 - (void)insertYogaChild:(ASDisplayNode *)child atIndex:(NSUInteger)index
@@ -118,7 +117,6 @@ - (void)_locked_insertYogaChild:(ASDisplayNode *)child atIndex:(NSUInteger)index
 
   // YGNodeRef insertion is done in setParent:
   child.yogaParent = self;
-  [self setNeedsLayout];
 }
 
 #pragma mark - Subclass Hooks
diff --git a/Source/Layout/ASLayoutElement.mm b/Source/Layout/ASLayoutElement.mm

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,6 @@ - (void)_locked_removeYogaChild:(ASDisplayNode *)child`
`93`	`93`
`94`	`94`	`// YGNodeRef removal is done in setParent:`
`95`	`95`	`child.yogaParent = nil;`
`96`		`- [self setNeedsLayout];`
`97`	`96`	`}`
`98`	`97`
`99`	`98`	`- (void)insertYogaChild:(ASDisplayNode *)child atIndex:(NSUInteger)index`
`@@ -118,7 +117,6 @@ - (void)_locked_insertYogaChild:(ASDisplayNode *)child atIndex:(NSUInteger)index`
`118`	`117`
`119`	`118`	`// YGNodeRef insertion is done in setParent:`
`120`	`119`	`child.yogaParent = self;`
`121`		`- [self setNeedsLayout];`
`122`	`120`	`}`
`123`	`121`
`124`	`122`	`#pragma mark - Subclass Hooks`