StarRocks supports querying Hive tables with encrypted ORC file format #46809
+1,765
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
let me have a review |
DorianZheng
reviewed
Jun 12, 2024
| @@ -18,6 +18,8 @@ | |||
|
|
|||
| #include "exec/exec_node.h" | |||
| #include "exec/iceberg/iceberg_delete_builder.h" | |||
| #include "exprs/base64.h" | |||
| #include "formats/orc/apache-orc/c++/src/security/InMemoryKeystore.hh" | |||
There was a problem hiding this comment.
We should put all the ORC-related header files which are exposed to users in apache-orc/c++/include/orc
| @@ -40,6 +40,7 @@ | |||
|
|
|||
| public class Config extends ConfigBase { | |||
|
|
|||
|
|
|||
| @@ -168,6 +168,7 @@ HdfsTableDescriptor::HdfsTableDescriptor(const TTableDescriptor& tdesc, ObjectPo | |||
| _hdfs_base_path = tdesc.hdfsTable.hdfs_base_dir; | |||
| _columns = tdesc.hdfsTable.columns; | |||
| _partition_columns = tdesc.hdfsTable.partition_columns; | |||
| _properties = tdesc.hdfsTable.properties; | |||
There was a problem hiding this comment.
need to check __isset.properties first
|
Ping . Is the CLA/DCO sign necessary or optional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Spark 2.4.x uses the Java version of the Apache OCR project to enable encryption and decryption of ORC format Hive tables.
StarRocks uses the C++ version of the Apache OCR project for reading and writing OCR files, but the C++ version does not implement encryption and decryption functionality. When performing ad-hoc analysis on Hive tables with encrypted columns, StarRocks is unable to query the Hive table. Therefore, modifications need to be made to StarRocks' Apache OCR module to support reading encrypted Hive table data in ORC format.
What I'm doing:
Fixes #issue
StarRocks supports querying Hive tables with encrypted ORC file format #45777
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: