Description
Describe the bug
When using schematic to generate / update the project, among others, the file spartacus-features.module.ts
is generated / updated
Within the spartacus code, this file has the following section:
/************************* Opt-in features *************************/
ExternalRoutesModule.forRoot(), // to opt-in explicitly, is added by default schematics
JsonLdBuilderModule,
/************************* External features *************************/
After running the schematics, the generated file spartacus-features.module.ts
in my project does NOT contain the line ExternalRoutesModule.forRoot()
Tell us the version of Spartacus
- Library version: 3.3.0
To Reproduce
Steps to reproduce the behavior:
- Generate a fresh spartacus project
- Open the file
spartacus-features.module.ts
- Notice that the file does not contain the ExternalRoutesModule
Expected behavior
According to the comment within the file in the spartacus codebase // to opt-in explicitly, is added by default schematics
and since the documentation about the feature does not say anything about opting in manually (https://sap.github.io/spartacus-docs/external-routes/), I would expect, that the schematics adds the line according to the spartacus version of the file spartacus-features.module.ts
.
Screenshots
Spartacus Feature Module:
Desktop (please complete the following information):
- OS: all
- Browser all
- Version all
Smartphone (please complete the following information):
- Device: all
- OS: all
- Browser all
- Version all
Other Ticket about External Routing
#12292
Activity
giancorderoortiz commentedon Jun 8, 2021
@marlass fyi.
Merge remote-tracking branch 'origin/feature/GH-12320' into feature/G…
Merge remote-tracking branch 'origin/develop' into feature/GH-12486
Merge remote-tracking branch 'origin/develop' into feature/GH-12486
Merge remote-tracking branch 'origin/develop' into feature/GH-12486
Merge branch 'develop' into feature/GH-12486
Merge branch 'develop' into feature/GH-12486
fix: Schematics - add ExternalRouting to the feature set (#12780)
fix: Schematics - add ExternalRouting to the feature set (#12780)
fix: Schematics - add ExternalRouting to the feature set (#12780)