Skip to content

ExternalRouting Module does not get added when generating / updating a project #12486

Closed
@janwidmer

Description

@janwidmer

Describe the bug
When using schematic to generate / update the project, among others, the file spartacus-features.module.ts is generated / updated

Within the spartacus code, this file has the following section:

/************************* Opt-in features *************************/

    ExternalRoutesModule.forRoot(), // to opt-in explicitly, is added by default schematics
    JsonLdBuilderModule,

    /************************* External features *************************/

After running the schematics, the generated file spartacus-features.module.ts in my project does NOT contain the line ExternalRoutesModule.forRoot()

Tell us the version of Spartacus

  • Library version: 3.3.0

To Reproduce
Steps to reproduce the behavior:

  1. Generate a fresh spartacus project
  2. Open the file spartacus-features.module.ts
  3. Notice that the file does not contain the ExternalRoutesModule

Expected behavior
According to the comment within the file in the spartacus codebase // to opt-in explicitly, is added by default schematics and since the documentation about the feature does not say anything about opting in manually (https://sap.github.io/spartacus-docs/external-routes/), I would expect, that the schematics adds the line according to the spartacus version of the file spartacus-features.module.ts.

Screenshots
Spartacus Feature Module:
image

Desktop (please complete the following information):

  • OS: all
  • Browser all
  • Version all

Smartphone (please complete the following information):

  • Device: all
  • OS: all
  • Browser all
  • Version all

Other Ticket about External Routing
#12292

Activity

giancorderoortiz

giancorderoortiz commented on Jun 8, 2021

@giancorderoortiz
Contributor
self-assigned this
on Jun 10, 2021
added a commit that references this issue on Jun 15, 2021
added a commit that references this issue on Jun 15, 2021
added 2 commits that reference this issue on Jun 15, 2021
29f91f7
0611c65
added a commit that references this issue on Jun 15, 2021
84ded05
added this to the before-5.0 milestone on Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    Participants

    @janwidmer@Xymmer@znikola@giancorderoortiz

    Issue actions

      ExternalRouting Module does not get added when generating / updating a project · Issue #12486 · SAP/spartacus