Skip to content

Logo, favicon and stores icon are not displayed in the 1.7.7.0-RC.1 #21979

Closed
@PierreRambaud

Description

@PierreRambaud
Contributor

Describe the bug

Since the latest changes on 1.7.7.x, themes are broken after an upgrade.

For example in the classic theme we now have:

  <link rel="icon" type="image/vnd.microsoft.icon" href="{$urls.img_ps_url}{$shop.favicon}?{$shop.favicon_update_time}">

When it should be

  <link rel="icon" type="image/vnd.microsoft.icon" href="{$shop.favicon}?{$shop.favicon_update_time}">

Expected behavior

We should be able to reach logo, stores_icon, favicon without having to put the _PS_IMG_ constant before.

Steps to Reproduce

Steps to reproduce the behavior:

Use a theme that is not the classic theme
For example: https://github.com/prestarocket-agence/classic-rocket

Additional information

  • PrestaShop version: 1.7.7.x
  • PHP version: N/A

Activity

added
Must-haveKanban prioritization: issue must be included in next version
on Nov 18, 2020
added this to the 1.7.7.0 milestone on Nov 18, 2020
ghost

ghost commented on Nov 18, 2020

@ghost

@PierreRambaud you don't have to use an other theme juste skip update theme during install it's easier for test :)

added
Theme & logoLabel: Which BO under menu is concerned
ReadyStatus: Issue is ready to be worked on
FOCategory: Front Office
on Nov 18, 2020

16 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

1.7.7.xBranchBugType: BugFOCategory: Front OfficeFixedResolution: issue closed because fixedModules & ThemesComponent: Which BO section is concernedMust-haveKanban prioritization: issue must be included in next versionPR availableSolution: issue is being addressedRegressionType: regressionTheme & logoLabel: Which BO under menu is concerned

Type

No type

Projects

No projects

Relationships

None yet

    Participants

    @PierreRambaud@Progi1984@marionf@khouloudbelguith@SimonGrn

    Issue actions

      Logo, favicon and stores icon are not displayed in the 1.7.7.0-RC.1 · Issue #21979 · PrestaShop/PrestaShop