Skip to content

BO - Order page - Try to remve a Voucher (gift) => an error is displayed #21810

New issue
New issue
Closed
Listed in
#17598
Closed
BO - Order page - Try to remve a Voucher (gift) => an error is displayed#21810
Listed in
#17598
Assignees
Darmona
Labels
1.7.7.0Affects versionsBOCategory: Back OfficeBugType: BugCart rulesLabel: Which BO under menu is concernedDiscountsLabel: Which BO under menu is concernedFixedResolution: issue closed because fixedMinorSeverity: minor bug > https://build.prestashop.com/news/severity-classificationNice-to-haveKanban prioritization: issue could be included in next versionOrderComponent: Which BO section is concernedRegressionType: regressionmigrationsymfony migration project
@khouloudbelguith

Description

@khouloudbelguith
khouloudbelguith
opened on Nov 9, 2020
Contributor

Describe the bug

An error is displayed when removing a voucher (gift) with no code

Expected behavior

The Voucher line should be removed

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to BO > Catalog > Discounts page
  2. Create a cart rule:
    2.1 Informations: No code
    2.2 Conditions: No conditions
    2.3 Actions: send a gift
    image
  3. Go to BO > Order page > Add a new order for "John Doe"
  4. Add a product to the cart (the cart rule well applied)
  5. Try to remove the cart rule
  6. see the error
    image

Same issue with 1770rc1build3

1770rc1build2 => ok

Additional information

  • PrestaShop version: 1.7.7.0rc1build4
  • PHP version: 7.2

Activity

khouloudbelguith
added
1.7.7.0Affects versions
BOCategory: Back Office
Cart rulesLabel: Which BO under menu is concerned
DiscountsLabel: Which BO under menu is concerned
MinorSeverity: minor bug > https://build.prestashop.com/news/severity-classification
RegressionType: regression
ReadyStatus: Issue is ready to be worked on
OrderComponent: Which BO section is concerned
BugType: Bug
migrationsymfony migration project
on Nov 9, 2020
khouloudbelguith
mentioned this on Nov 9, 2020
marionf
added
Nice-to-haveKanban prioritization: issue could be included in next version
on Nov 9, 2020
marionf

marionf commented on Nov 18, 2020

@marionf
marionf
on Nov 18, 2020
Contributor

This error should be fixed is ps_checkout module

marionf
self-assigned this
on Nov 18, 2020
Progi1984

Progi1984 commented on Nov 18, 2020

@Progi1984
Progi1984
on Nov 18, 2020
Member

Information :

It comes from modules/ps_checkout/ps_checkout.php in the method hookActionCartUpdateQuantityBefore where the variable $this->context->cart->id is not checked.

marionf

marionf commented on Nov 18, 2020

@marionf
marionf
on Nov 18, 2020
Contributor

@khouloudbelguith Can you tell me what is the version of ps_checkout in your shop ?

marionf
assigned
Darmona
and unassigned
marionf
on Nov 18, 2020
Matt75
mentioned this on Nov 18, 2020
marionf
added
WIPStatus: Work In Progress
and removed
ReadyStatus: Issue is ready to be worked on
on Nov 18, 2020
marionf

marionf commented on Nov 18, 2020

@marionf
marionf
on Nov 18, 2020
Contributor

Fixed by: PrestaShopCorp/ps_checkout#614

marionf
closed this as completedon Nov 18, 2020
marionf
added
FixedResolution: issue closed because fixed
and removed
WIPStatus: Work In Progress
on Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

1.7.7.0Affects versionsBOCategory: Back OfficeBugType: BugCart rulesLabel: Which BO under menu is concernedDiscountsLabel: Which BO under menu is concernedFixedResolution: issue closed because fixedMinorSeverity: minor bug > https://build.prestashop.com/news/severity-classificationNice-to-haveKanban prioritization: issue could be included in next versionOrderComponent: Which BO section is concernedRegressionType: regressionmigrationsymfony migration project

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @Progi1984@marionf@khouloudbelguith@Darmona

      Issue actions
        BO - Order page - Try to remve a Voucher (gift) => an error is displayed · Issue #21810 · PrestaShop/PrestaShop