Minor shader fixes #2901
Minor shader fixes #2901
Conversation
Capostrophic
commented
Jun 9, 2020
Capostrophic
commented
- simpleWater bool is not set to false by default anymore. Uniforms are initialized to zero by default which corresponds to false, so this shouldn't be necessary, and GL4ES doesn't support initializers for uniforms right now and currently has to manually do the same thing done here.
- Most objects in the game only have a diffuse map and don't have specularity, but while handling the diffuse map is obviously necessary, the per-fragment specularity calculations in the shaders used for all objects should be avoided whenever possible. Per suggestion of akortunov, getSpecular call isn't done for objects that have a black specular color in their material as well as terrain. This seems to result in a ~10% higher framerate on a GeForce GTX 1050 when shaders are used (of course it depends on whether shadows and water shader are used), while on older video cards it may not lead to discernible benefit but certainly shouldn't lead to a discernible loss either. Should probably resolve 5428, as there isn't much that can be done otherwise; I thought about making specular lighting per-vertex when the entire lighting is per-vertex, but given that there are at least four situations that should be taken care of — per-vertex material specularity, per-vertex specular map specularity (shouldn't be a thing), per-pixel material specularity, per-pixel specular map specularity — it has proven to complicate shaders much more than what I'm comfortable with. Maybe later.
Don't initialize uniform bool to false explicitly Attempt not to calculate specular lighting if the material specular color is black
|
Also this PR improves situation with bug #4952. |
|
Yeah, I guess the only situation where this would make things worse is on older GPUs without jump instructions, and the only extra thing would be a single multiplication by zero which the optimiser would probably remove as when it happened, the thing would already be being multiplied by zero. LGTM. |
|
Doing viewNormal calculation inside the if statement when With GPU frequency at 100MHz:
(Most of the rest of the difference here is because all the extra uniforms force UBOs to be used instead of register uniforms) |
Sorry, I do not understand what you want. The |
|
He probably mean that |
