Handle NiLines (feature #5445) #2883
Merged
+101
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of this based on what is known about the record, using LINES primitives in OpenSceneGraph.
The way geometry is handled in NIF loader has been made even more generic.
No Bullet-side changes, i.e. there won't be any autogenerated (so called face/triangle) collision for the lines, because there aren't any triangles or faces to speak of.
This is how the test model I was given looks like:
Which looks pretty similar to how it looks in SceneImmerse.
It'll be difficult to test the original behavior as in Morrowind NiLines objects can only be loaded with the most recent MWSE 2.0 build which patches their loading. NifSkope doesn't properly support NiLines records either.