fix(types): 添加缺失的类型定义 #7055
Merged
fix(types): 添加缺失的类型定义 #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
在官方合并以及等待下一次发版之前，打开 global.d.ts： declare module '@tarojs/taro' {
interface PageConfig {
/**
* 是否启用分享给好友。
*
* @default false
*/
enableShareAppMessage?: boolean
/**
* 是否启用分享到朋友圈。
*
* @default false
*/
enableShareTimeline?: boolean
}
} |
|
太棒了 |
luckyadam
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
为该 PR 添加用户侧的类型定义：#6996
同时希望官方在功能改动时也考虑同步类型的改动。
另外，我觉得 #6996 带来的 breaking changes 似乎不太妥当，似乎用 disableShareAppMessage、disableShareTimeline 更为合适，一是因为这样不会带来任何不兼容更新，二是其实更多的需求是让用户分享，而不是禁止用户分享，一个十分常用的功能却要手动在每个页面开启是十分令人抓狂的。
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：