Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

onCompletion block is executing X times (more than twice!) #447

Open
@frranck

Description

@frranck

If i do the same GET (same url) in // 5 times. (with the caching off.)
each different completion function will be called multiple times (more than 2, sometime up to 4 times)

It can be patched by changing the uniqueIdentifier function in MKNetworkOperation.m

-(NSString *) uniqueIdentifier {  
  //NSMutableString *str = [NSMutableString stringWithFormat:@"%@ %@ %@", self.request.HTTPMethod, self.url, self.responseBlocks];
    NSMutableString *str = [NSMutableString stringWithFormat:@"%@ %@", self.request.HTTPMethod, self.url];

But it seems like a meant behaviour, could i get a feedback on it ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @frranck

        Issue actions

          onCompletion block is executing X times (more than twice!) · Issue #447 · MKSG-MugunthKumar/MKNetworkKit